You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2016/08/05 14:26:52 UTC
Review Request 50852: ATLAS-1099 : UI : multiple tag assign button
hides wrongly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50852/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.
Bugs: ATLAS-1099
https://issues.apache.org/jira/browse/ATLAS-1099
Repository: atlas
Description
-------
Following issues are resolved in this patch:
* After selecting multiple tags to assign with entity, even if we de-select one tag, "Assign Tags" button gets hidden.
* Remove tag popup was overlapping the close div of tag.
* In case of client pagination, page size was shown 1-0 when no records were found, instead of showing 0-0.
* Search Tag from Left Navigation was not populated in search input box (in the DSL list of types) -- this patch populates the Searched type in the first textbox of "Select Types".
Diffs
-----
dashboardv2/public/css/scss/form.scss 0cae6f6
dashboardv2/public/css/scss/override.scss bbcc319
dashboardv2/public/css/scss/search.scss 959405e
dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 7eb14b3
dashboardv2/public/js/utils/TableLayout.js 96251a2
dashboardv2/public/js/views/audit/AuditTableLayoutView.js 6d2f722
dashboardv2/public/js/views/schema/SchemaLayoutView.js 228ef7d
dashboardv2/public/js/views/search/SearchLayoutView.js fc30649
dashboardv2/public/js/views/search/SearchResultLayoutView.js 4b3a8e1
Diff: https://reviews.apache.org/r/50852/diff/
Testing
-------
Verified complete UI functionality with data on atlas in hive look.
Thanks,
Kalyani Kashikar
Re: Review Request 50852: ATLAS-1099 : UI : multiple tag assign
button hides wrongly
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50852/#review144944
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 5, 2016, 2:26 p.m., Kalyani Kashikar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50852/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2016, 2:26 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1099
> https://issues.apache.org/jira/browse/ATLAS-1099
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Following issues are resolved in this patch:
>
> * After selecting multiple tags to assign with entity, even if we de-select one tag, "Assign Tags" button gets hidden.
> * Remove tag popup was overlapping the close div of tag.
> * In case of client pagination, page size was shown 1-0 when no records were found, instead of showing 0-0.
> * Search Tag from Left Navigation was not populated in search input box (in the DSL list of types) -- this patch populates the Searched type in the first textbox of "Select Types".
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/form.scss 0cae6f6
> dashboardv2/public/css/scss/override.scss bbcc319
> dashboardv2/public/css/scss/search.scss 959405e
> dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 7eb14b3
> dashboardv2/public/js/utils/TableLayout.js 96251a2
> dashboardv2/public/js/views/audit/AuditTableLayoutView.js 6d2f722
> dashboardv2/public/js/views/schema/SchemaLayoutView.js 228ef7d
> dashboardv2/public/js/views/search/SearchLayoutView.js fc30649
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 4b3a8e1
>
> Diff: https://reviews.apache.org/r/50852/diff/
>
>
> Testing
> -------
>
> Verified complete UI functionality with data on atlas in hive look.
>
>
> Thanks,
>
> Kalyani Kashikar
>
>