[GitHub] [pinot] navina commented on a diff in pull request #9608: Using `usageHelp` instead of deprecated `help` in picocli commands

[GitBox <gi...@apache.org>]

navina commented on code in PR #9608:
URL: https://github.com/apache/pinot/pull/9608#discussion_r1001001394


##########
pinot-tools/src/main/java/org/apache/pinot/tools/AutoAddInvertedIndexTool.java:
##########
@@ -66,23 +66,18 @@ public class AutoAddInvertedIndexTool extends AbstractBaseCommand implements Com
           + AutoAddInvertedIndex.DEFAULT_MAX_NUM_INVERTED_INDEX_ADDED)
   private int _maxNumInvertedIndex = AutoAddInvertedIndex.DEFAULT_MAX_NUM_INVERTED_INDEX_ADDED;
 
-  @CommandLine.Option(names = {"-help", "-h", "--h", "--help"}, required = false, help = true,
+  @CommandLine.Option(names = {"-help", "-h", "--h", "--help"}, required = false, usageHelp = true,
       description = "Print this message.")
   private boolean _help = false;
 
   @Override
-  public boolean getHelp() {
-    return _help;
-  }
-
-  @Override
-  public String getName() {

Review Comment:
   likely



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org