[GitHub] [beam] je-ik commented on a change in pull request #14013: [BEAM-11833] Fix reported watermark after restriction split in UnboundedSourceAsSDFRestrictionTracker

[GitBox <gi...@apache.org>]

je-ik commented on a change in pull request #14013:
URL: https://github.com/apache/beam/pull/14013#discussion_r582635836



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -789,6 +799,7 @@ public CheckpointMark getCheckpointMark() {
       private boolean readerHasBeenStarted;
       private Cache<Object, UnboundedReader<OutputT>> cachedReaders;
       private Coder<UnboundedSourceRestriction<OutputT, CheckpointT>> restrictionCoder;
+      private Instant lastPreSplitWatermark;

Review comment:
       Yes, you are right that it under current implementation probably plays no role. On the other hand, I'd like to avoid updating the watermark estimator to `BoundedWindow.TIMESTAMP_MAX_VALUE` (if that is not what actually came from the reader). Therefore, I'd propose to add method `isSplit` to `UnboundedSourceRestiction` and do not update the watermark estimator if that is the case (which then should result in returning `ProcessContinuation.done()`, which should be OK).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org