[GitHub] [trafficserver] sudheerv commented on pull request #7516: Adding TCP Info header support to header rewrite

[GitBox <gi...@apache.org>]

sudheerv commented on pull request #7516:
URL: https://github.com/apache/trafficserver/pull/7516#issuecomment-810511497


   > > I'm also curious on how this information is intended to be used. If the intention is for mainly exposing the TCP-INFO to access logs, I wonder if it makes sense to consider using log tags instead of header-rewrite operator?
   > 
   > Yeh, primarily for logs. Moving it to the core is an option, but the thought was to avoid polluting the core more with a bunch of #ifdef's (and also makes it more difficult for people to make custom additions or changes). But if the consensus is that it'd be better to move this to the core, rather than a plugin, I'm fine with that too.
   
   Makes sense. The only downside (that I can think of), for not having it as first class log tags is that it may not be "obvious" that this capability even exists, but, I guess the pros of being able to further customize it is definitely appealing. Also, I think if when we want to add this to log tags, it can co-exist with the header-rewrite operator too like a few other similar context info that we support in header-rewrite. Plus, there may be some legit use cases where someone may actually want to transport this info along to their downstream services for offline processing and supporting it via header-rewrite does make that part easier. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org