You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 05:02:43 UTC
[GitHub] [spark] LuciferYang opened a new pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
LuciferYang opened a new pull request #34237:
URL: https://github.com/apache/spark/pull/34237
### What changes were proposed in this pull request?
The `date_format` function with `B` format has different behavior when use Java 8 and Java 17, `select date_format('2018-11-17 13:33:33.333', 'B')` in `datetime-formatting-invalid.sql` can prove this.
The case result with Java 8 is
```
-- !query
select date_format('2018-11-17 13:33:33.333', 'B')
-- !query schema
struct<>
-- !query output
java.lang.IllegalArgumentException
Unknown pattern letter: B
```
and the case result with Java 17 is
```
- datetime-formatting-invalid.sql *** FAILED ***
datetime-formatting-invalid.sql
Expected "struct<[]>", but got "struct<[date_format(2018-11-17 13:33:33.333, B):string]>" Schema did not match for query #34
select date_format('2018-11-17 13:33:33.333', 'B'): -- !query
select date_format('2018-11-17 13:33:33.333', 'B')
-- !query schema
struct<date_format(2018-11-17 13:33:33.333, B):string>
-- !query output
in the afternoon (SQLQueryTestSuite.scala:469)
```
We found that this is due to the new support of format `B` in Java 17
```
'B' is used to represent Pattern letters to output a day period in Java 17
* Pattern Count Equivalent builder methods
* ------- ----- --------------------------
* B 1 appendDayPeriodText(TextStyle.SHORT)
* BBBB 4 appendDayPeriodText(TextStyle.FULL)
* BBBBB 5 appendDayPeriodText(TextStyle.NARROW)
```
And through [ http://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html]( http://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html) , we can confirm that format `B` is not documented/supported for `date_format` function currently.
So the main change of this pr is manual disabled format `B` of `date_format` function in `DateTimeFormatterHelper` to make Java 17 compatible with Java 8.
### Why are the changes needed?
Ensure that Java 17 and Java 8 have the same behavior.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the Jenkins or GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940105720
**[Test build #144078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144078/testReport)** for PR 34237 at commit [`8271b47`](https://github.com/apache/spark/commit/8271b478ef0b808662c08c95cf852f6cd8cef3f4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939686741
cc @srowen @MaxGekk @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939684114
**[Test build #144066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144066/testReport)** for PR 34237 at commit [`1bc02ad`](https://github.com/apache/spark/commit/1bc02ada576440f9a49e6e51e0eb1e8ddf393ebb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940951706
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48620/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r725918543
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
OK ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941203890
**[Test build #144152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144152/testReport)** for PR 34237 at commit [`ac2e700`](https://github.com/apache/spark/commit/ac2e7007b0d37ec7f6af6e8375f03e24174ac59a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940833467
**[Test build #144143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144143/testReport)** for PR 34237 at commit [`0ad1959`](https://github.com/apache/spark/commit/0ad19592f8c05e36fe6d18adf72bae8772a23b2f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941748274
Thank you all. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941205654
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144152/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941037803
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48630/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939743065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48544/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940007468
**[Test build #144072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144072/testReport)** for PR 34237 at commit [`c6713ce`](https://github.com/apache/spark/commit/c6713ce479ffa9c42c6f5b2222ab60b82e2aa864).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class SetCatalogAndNamespace(child: LogicalPlan) extends UnaryCommand `
* `case class SetNamespaceCommand(namespace: Seq[String]) extends LeafRunnableCommand `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940872958
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144143/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r725893803
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
@MaxGekk Both `unsupportedLetters` and `unknownPatternLetters` are used for explicitly banned some
pattern letters and throw `IllegalArgumentException`
The only difference is the content of the error message, throw `IllegalArgumentException` with `Unknown pattern letter: $c` Is the current behavior.
If we accept the change of error message content, we can reuse `unsupportedLetters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r725893803
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
@MaxGekk Both `unsupportedLetters` and `unknownPatternLetters` are used for explicitly banned some pattern letters and throw `IllegalArgumentException`
The only difference is the content of the error message, throw `IllegalArgumentException` with `Unknown pattern letter: $c` Is the current behavior.
If we accept the change of error message content, we can reuse `unsupportedLetters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34237:
URL: https://github.com/apache/spark/pull/34237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939701199
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48544/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940112367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144078/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939994843
Looks really nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941093321
Already re-trigger GAs many times，it seems that I need to investigate the reasons for the failure of hive SlowTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939788949
**[Test build #144072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144072/testReport)** for PR 34237 at commit [`c6713ce`](https://github.com/apache/spark/commit/c6713ce479ffa9c42c6f5b2222ab60b82e2aa864).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939684114
**[Test build #144066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144066/testReport)** for PR 34237 at commit [`1bc02ad`](https://github.com/apache/spark/commit/1bc02ada576440f9a49e6e51e0eb1e8ddf393ebb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940763233
@LuciferYang Could you re-trigger GAs via an empty commit:
```
$ git commit --allow-empty -m "Trigger build"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940833467
**[Test build #144143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144143/testReport)** for PR 34237 at commit [`0ad1959`](https://github.com/apache/spark/commit/0ad19592f8c05e36fe6d18adf72bae8772a23b2f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939788949
**[Test build #144072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144072/testReport)** for PR 34237 at commit [`c6713ce`](https://github.com/apache/spark/commit/c6713ce479ffa9c42c6f5b2222ab60b82e2aa864).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939882886
**[Test build #144078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144078/testReport)** for PR 34237 at commit [`8271b47`](https://github.com/apache/spark/commit/8271b478ef0b808662c08c95cf852f6cd8cef3f4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941048806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940600759
> Could you re-trigger GitHub Action once more, @LuciferYang ?
OK, the exit code is 137. It looks like it was killed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939725494
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48544/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r725865891
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
What's the difference between unsupported and unknown letters from your point of view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940112367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144078/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939879670
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48550/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939959338
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48556/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939882982
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144066/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939743065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48544/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941205654
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144152/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941850676
thank all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r725903698
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
> If we accept the change of error message content ...
I think it is ok. Let's put 'B' to `unsupportedLetters`. BTW, should we standardise the exception by following https://issues.apache.org/jira/browse/SPARK-33539, cc @allisonwang-db ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34237:
URL: https://github.com/apache/spark/pull/34237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940872800
**[Test build #144143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144143/testReport)** for PR 34237 at commit [`0ad1959`](https://github.com/apache/spark/commit/0ad19592f8c05e36fe6d18adf72bae8772a23b2f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` protected class YarnSchedulerEndpoint(override val rpcEnv: RpcEnv)`
* `case class HashedRelationBroadcastMode(key: Seq[Expression], isNullAware: Boolean = false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940872958
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144143/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941205654
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144152/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939882886
**[Test build #144078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144078/testReport)** for PR 34237 at commit [`8271b47`](https://github.com/apache/spark/commit/8271b478ef0b808662c08c95cf852f6cd8cef3f4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940338017
Could you re-trigger GitHub Action once more, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939967251
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48556/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940953253
**[Test build #144152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144152/testReport)** for PR 34237 at commit [`ac2e700`](https://github.com/apache/spark/commit/ac2e7007b0d37ec7f6af6e8375f03e24174ac59a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940989832
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48628/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941850676
thank all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940951706
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48620/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940989351
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48630/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941208188
+1, LGTM. Merging to master. All GAs passed
<img width="437" alt="Screenshot 2021-10-12 at 20 11 56" src="https://user-images.githubusercontent.com/1580697/137000224-bc3d00b7-69cf-4e8d-8719-d5d7e83e9e67.png">
Thank you, @LuciferYang and @srowen @dongjoon-hyun @allisonwang-db for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939967251
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48556/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940953253
**[Test build #144152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144152/testReport)** for PR 34237 at commit [`ac2e700`](https://github.com/apache/spark/commit/ac2e7007b0d37ec7f6af6e8375f03e24174ac59a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r726488711
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
Awesome thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939879670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
srowen removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939994843
Looks really nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939857805
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48550/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939821801
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48550/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r725893803
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
@MaxGekk Both `unsupportedLetters` and `unknownPatternLetters` are used for explicitly banned some pattern letters and throw `IllegalArgumentException`
The only difference is the content of the error message, throw `IllegalArgumentException` with `Unknown pattern letter: $c` Is the current behavior.
https://github.com/apache/spark/blob/32e11ea1423ec25ed6a6b9aedaa7a9d26220244a/sql/core/src/test/resources/sql-tests/results/datetime-formatting-invalid.sql.out#L311-L317
If we accept the change of error message content, we can reuse `unsupportedLetters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941208188
+1, LGTM. Merging to master. All GAs passed
<img width="437" alt="Screenshot 2021-10-12 at 20 11 56" src="https://user-images.githubusercontent.com/1580697/137000224-bc3d00b7-69cf-4e8d-8719-d5d7e83e9e67.png">
Thank you, @LuciferYang and @srowen @dongjoon-hyun @allisonwang-db for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940899955
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48620/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940953253
**[Test build #144152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144152/testReport)** for PR 34237 at commit [`ac2e700`](https://github.com/apache/spark/commit/ac2e7007b0d37ec7f6af6e8375f03e24174ac59a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941205654
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144152/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940613043
@dongjoon-hyun
TPCDS passed although other tests are still running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941048806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941037339
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48628/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940335743
Oh, I'm taking my words back. It seems that there is a TPCDS test failure still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940011224
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939917355
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48556/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940930667
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48620/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941203890
**[Test build #144152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144152/testReport)** for PR 34237 at commit [`ac2e700`](https://github.com/apache/spark/commit/ac2e7007b0d37ec7f6af6e8375f03e24174ac59a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-941748274
Thank you all. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-939881039
**[Test build #144066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144066/testReport)** for PR 34237 at commit [`1bc02ad`](https://github.com/apache/spark/commit/1bc02ada576440f9a49e6e51e0eb1e8ddf393ebb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34237:
URL: https://github.com/apache/spark/pull/34237#issuecomment-940011224
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org