You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2014/01/09 12:27:50 UTC

[jira] [Created] (DERBY-6453) Remove dead code in InsertResultSet and flag skipCheckConstraints

Dag H. Wanvik created DERBY-6453:
------------------------------------

             Summary: Remove dead code in InsertResultSet and flag skipCheckConstraints
                 Key: DERBY-6453
                 URL: https://issues.apache.org/jira/browse/DERBY-6453
             Project: Derby
          Issue Type: Improvement
          Components: SQL
            Reporter: Dag H. Wanvik
            Priority: Minor


I identified some unused code; a flag that is always false, and code for handling triggers in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression tests): we disable bulk insert if there are triggers present, cf. 

* DMLModStatementNode#getAllRelevantTriggers ->
  adjustDeferredFlag(true)

* InsertResultSet#bulkInsert:

  bulkInsert = verifyBulkInsert()->
      :
      // bulk insert is disabled for deferred mode inserts
      if (constants.deferred)
      return false;




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)