You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/01/06 15:55:16 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3382: ARTEMIS-3033 - implement address tree map for wildcards in place of l…

clebertsuconic commented on a change in pull request #3382:
URL: https://github.com/apache/activemq-artemis/pull/3382#discussion_r552737997



##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
##########
@@ -281,6 +283,27 @@ public String toString() {
       return str;
    }
 
+   public String[] getPaths(final char separator) {

Review comment:
       this is probably nit picking... 
   
   but if you called getPaths('.')
   
   and then getPaths('/');
   
   
   the second one would return the paths from the previous one.
   
   
   
   Should we care about that? or just add docs about it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org