[GitHub] [sling-org-apache-sling-xss] rombert commented on a diff in pull request #34: SLING-11882 shade guava library to avoid classpath problems in unit tests

["rombert (via GitHub)" <gi...@apache.org>]

rombert commented on code in PR #34:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/34#discussion_r1250977716


##########
pom.xml:
##########
@@ -172,6 +172,33 @@
                     </includes>
                 </configuration>
             </plugin>
+            <!-- Shade 3rdparty libs to avoid classpath conflicts in unit tests -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-shade-plugin</artifactId>
+                <configuration>
+                    <artifactSet>
+                        <includes>
+                            <include>com.google.guava:*</include>
+                        </includes>
+                    </artifactSet>
+                    <createSourcesJar>true</createSourcesJar>
+                    <relocations>
+                        <relocation>
+                            <pattern>com.google.common</pattern>
+                            <shadedPattern>sling-xss.com.google.common</shadedPattern>

Review Comment:
   Is this shadedPattern valid? Java package names cannot contain the `-` / dash character.
   
   ( https://docs.oracle.com/javase/specs/jls/se16/html/jls-3.html#jls-Identifier , https://docs.oracle.com/javase/specs/jls/se16/html/jls-7.html#jls-7.4.1 )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org