You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by sagitta20 <gi...@git.apache.org> on 2018/03/20 02:55:10 UTC

[GitHub] storm pull request #2602: Update CuratorUtils.java

GitHub user sagitta20 opened a pull request:

    https://github.com/apache/storm/pull/2602

    Update CuratorUtils.java

    If root isn't empty, there need a ',' before root

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sagitta20/storm patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2602
    
----
commit e855b84df9d7dcba865d4f94c1963437ff30b8a2
Author: sagitta20 <37...@...>
Date:   2018-03-20T02:47:00Z

    Update CuratorUtils.java
    
    If root isn't empty, there need a ',' before root

----


---

[GitHub] storm issue #2602: Update CuratorUtils.java

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2602
  
    Are you sure? The Zookeeper documentation doesn't mention using "," for root paths. From https://zookeeper.apache.org/doc/r3.4.11/api/index.html 
    
    > connectString - comma separated host:port pairs, each corresponding to a zk server. e.g. "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002" If the optional chroot suffix is used the example would look like: "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002/app/a" where the client would be rooted at "/app/a" and all paths would be relative to this root


---

[GitHub] storm pull request #2602: Update CuratorUtils.java

Posted by sagitta20 <gi...@git.apache.org>.

Github user sagitta20 closed the pull request at:

    https://github.com/apache/storm/pull/2602


---

[GitHub] storm issue #2602: Update CuratorUtils.java

Posted by sagitta20 <gi...@git.apache.org>.

Github user sagitta20 commented on the issue:

    https://github.com/apache/storm/pull/2602
  
    There is an exception when start nimbus in windows system. So I think there need a ','
    2018-03-19 17:30:47.995 o.a.s.s.o.a.z.ZooKeeper main [INFO] Initiating client connection, **connectString=zktest1.service.djdns.cn:2181,zktest2.service.djdns.cn:2181,zktest3.service.djdns.cn:2181aaa** sessionTimeout=20000 watcher=org.apache.storm.shade.org.apache.curator.ConnectionState@18d003cd
    2018-03-19 17:30:47.995 o.a.s.s.o.a.c.f.i.CuratorFrameworkImpl main [ERROR] Background exception was not retry-able or retry gave up
    java.lang.NumberFormatException: For input string: "**2181aaa**"
    	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) ~[?:1.8.0_102]
    	at java.lang.Integer.parseInt(Integer.java:580) ~[?:1.8.0_102]
    	at java.lang.Integer.parseInt(Integer.java:615) ~[?:1.8.0_102]
    	at org.apache.storm.shade.org.apache.zookeeper.client.ConnectStringParser.<init>(ConnectStringParser.java:72) ~[storm-core-1.2.1.jar:1.2.1]
    	at org.apache.storm.shade.org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:443) ~[storm-core-1.2.1.jar:1.2.1]
    	at org.apache.storm.shade.org.apache.curator.utils.DefaultZookeeperFactory.newZooKeeper(DefaultZookeeperFactory.java:29) ~[storm-core-1.2.1.jar:1.2.1]
    	at org.apache.storm.shade.org.apache.curator.framework.imps.CuratorFrameworkImpl$2.newZooKeeper(CuratorFrameworkImpl.java:191) ~[storm-core-1.2.1.jar:1.2.1]


---