You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/15 14:15:30 UTC
[GitHub] [incubator-yunikorn-core] chia7712 commented on a change in pull request #303: YUNIKORN-798 the REST APIs of getting queue application returns "Queu…
chia7712 commented on a change in pull request #303:
URL: https://github.com/apache/incubator-yunikorn-core/pull/303#discussion_r689096302
##########
File path: pkg/webservice/handlers.go
##########
@@ -687,28 +687,25 @@ func getQueueApplications(w http.ResponseWriter, r *http.Request) {
buildJSONErrorResponse(w, "Incorrect URL path. Please check the usage documentation", http.StatusBadRequest)
return
}
- var appExistsInPartition = false
- var appExistsInQueue = false
- var appsDao []*dao.ApplicationDAOInfo
+
partitionContext := schedulerContext.GetPartitionWithoutClusterID(partition)
- if partitionContext != nil {
- appExistsInPartition = true
- appList := partitionContext.GetApplications()
Review comment:
this call copy all applications of whole partition. this PR optimizes it by copying apps from only specify queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org