You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2019/07/03 13:22:04 UTC
[maven-integration-testing] 01/01: [MNG-4385] Avoid failse positive
for unrelated errors
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch MNG-4385
in repository https://gitbox.apache.org/repos/asf/maven-integration-testing.git
commit 1dc554edfcd45a9393cdd68530c8220015019e2a
Author: Joseph Walton <jo...@kafsemo.org>
AuthorDate: Wed Jul 3 22:15:32 2019 +1000
[MNG-4385] Avoid failse positive for unrelated errors
Inspect the log to be confident that this build is failing because
the extension hasn't carried over to the second module.
This closes #44
---
.../java/org/apache/maven/it/MavenITmng2576MakeLikeReactorTest.java | 2 +-
.../it/MavenITmng4385LifecycleMappingFromExtensionInReactorTest.java | 4 ++++
.../apache/maven/it/MavenITmng5230MakeReactorWithExcludesTest.java | 2 +-
.../maven/its/mng0449/maven-it-plugin-b/0.1/maven-it-plugin-b-0.1.pom | 2 +-
core-it-support/core-it-plugins/maven-it-plugin-packaging/pom.xml | 2 +-
5 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2576MakeLikeReactorTest.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2576MakeLikeReactorTest.java
index 2d00f4d..fcc0113 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2576MakeLikeReactorTest.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2576MakeLikeReactorTest.java
@@ -232,7 +232,7 @@ public class MavenITmng2576MakeLikeReactorTest
}
/**
- * Verify that the project list can also specify aritfact ids.
+ * Verify that the project list can also specify artifact ids.
*/
public void testitMatchesByArtifactId()
throws Exception
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4385LifecycleMappingFromExtensionInReactorTest.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4385LifecycleMappingFromExtensionInReactorTest.java
index 3a900a3..1923365 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4385LifecycleMappingFromExtensionInReactorTest.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4385LifecycleMappingFromExtensionInReactorTest.java
@@ -58,6 +58,10 @@ public class MavenITmng4385LifecycleMappingFromExtensionInReactorTest
catch( VerificationException e )
{
// expected, should fail
+ String msg = e.getMessage();
+
+ assertTrue( "Failure should be due to unknown packaging", msg.contains( "Unknown packaging: it-packaging" ));
+ assertTrue( "Failure should be due to sub-b project", msg.contains( "The project org.apache.maven.its.mng4385:sub-b:0.1" ));
}
verifier.resetStreams();
}
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5230MakeReactorWithExcludesTest.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5230MakeReactorWithExcludesTest.java
index a4843f7..aed1eb1 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5230MakeReactorWithExcludesTest.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5230MakeReactorWithExcludesTest.java
@@ -231,7 +231,7 @@ public class MavenITmng5230MakeReactorWithExcludesTest
}
/**
- * Verify that the project list exclude can also specify aritfact ids.
+ * Verify that the project list exclude can also specify artifact ids.
*/
public void testitMatchesByArtifactIdExclude()
throws Exception
diff --git a/core-it-suite/src/test/resources/mng-0449/repo/org/apache/maven/its/mng0449/maven-it-plugin-b/0.1/maven-it-plugin-b-0.1.pom b/core-it-suite/src/test/resources/mng-0449/repo/org/apache/maven/its/mng0449/maven-it-plugin-b/0.1/maven-it-plugin-b-0.1.pom
index 0c6ec67..03d6783 100644
--- a/core-it-suite/src/test/resources/mng-0449/repo/org/apache/maven/its/mng0449/maven-it-plugin-b/0.1/maven-it-plugin-b-0.1.pom
+++ b/core-it-suite/src/test/resources/mng-0449/repo/org/apache/maven/its/mng0449/maven-it-plugin-b/0.1/maven-it-plugin-b-0.1.pom
@@ -29,7 +29,7 @@ under the License.
<name>Maven Integration Test Plugin :: Packaging</name>
<description>
- A test plugin that defines a custom aritfact handler ("it-artifact") and a new packaging type ("it-packaging").
+ A test plugin that defines a custom artifact handler ("it-artifact") and a new packaging type ("it-packaging").
</description>
<inceptionYear>2006</inceptionYear>
diff --git a/core-it-support/core-it-plugins/maven-it-plugin-packaging/pom.xml b/core-it-support/core-it-plugins/maven-it-plugin-packaging/pom.xml
index 06e2648..b7b161a 100644
--- a/core-it-support/core-it-plugins/maven-it-plugin-packaging/pom.xml
+++ b/core-it-support/core-it-plugins/maven-it-plugin-packaging/pom.xml
@@ -33,7 +33,7 @@ under the License.
<name>Maven IT Plugin :: Packaging</name>
<description>
- A test plugin that defines a custom aritfact handler ("it-artifact") and a new packaging type ("it-packaging").
+ A test plugin that defines a custom artifact handler ("it-artifact") and a new packaging type ("it-packaging").
</description>
<inceptionYear>2006</inceptionYear>