[GitHub] [superset] villebro commented on issue #15378: Temporal columns et al. are not adhered to when re-syncing column metadata

[GitBox <gi...@apache.org>]

villebro commented on issue #15378:
URL: https://github.com/apache/superset/issues/15378#issuecomment-871193572


   @john-bodley I think it should be safe to call the `alter_new_orm_column` method. Alternatively we probably shouldn't change the `is_dttm` value if it has been manually set. Looking more closely at this, if a column is e.g. `VARCHAR` and is set as temporal, resyncing the columns will remove the temporal flag. So I think something like this could be a good solution:
   - if the column type is unchanged, we don't call `alter_new_orm_column`, nor do we reset `is_dttm`.
   - if column type is changed, we call `alter_new_orm_column`, also setting `is_dttm` according to its default value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org