[GitHub] [superset] villebro commented on a change in pull request #18151: refactor: Moves the Explore form_data endpoint

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #18151:
URL: https://github.com/apache/superset/pull/18151#discussion_r791461686



##########
File path: superset/config.py
##########
@@ -585,7 +585,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
 }
 
 # Cache for chart form data
-CHART_FORM_DATA_CACHE_CONFIG: CacheConfig = {
+EXPLORE_FORM_DATA_CACHE_CONFIG: CacheConfig = {

Review comment:
       This is a breaking change that needs to be flagged in `UPDATING.md`. Related to this, I've been thinking we should add a config which makes it possible to restrict the cache types that can be used. By restricting to e.g. Redis, we could ensure that the service doesn't start up if the admin has forgotten to add a recently added cache config.

##########
File path: superset/explore/form_data/commands/create.py
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.

Review comment:
       nit: while these are not identical with the old `charts/form_data/command` packages, it would have been nice to move these to their new locations first so the change in logic could have been more transparently recorded in the PR diff.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org