You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/04/11 11:46:44 UTC
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19720
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
IMPALA-12055: Use jquery.min.js from local repo
Our website depends on
https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js
In some regions, it's pretty slow to get this file and usually fail at
last.
This adds the file to the asf-site branch so the website can use a local
copy of it. Also bumps the jquery version to 3.5.1 to match the master
branch.
Tests:
- Verified the pages locally.
Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
---
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
A js/jquery-3.5.1.min.js
M overview.html
7 files changed, 8 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/19720/1
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19720
to look at the new patch set (#2).
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
IMPALA-12055: Use jquery.min.js from local repo
Our website depends on
https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js
In some regions, it's pretty slow to get this file and it usually fails
at last.
This adds the file to the asf-site branch so the website can use a local
copy of it. Also bumps the jquery version to 3.5.1 to match the master
branch.
Tests:
- Verified the pages locally.
Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
---
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
A js/jquery-3.5.1.min.js
M overview.html
7 files changed, 8 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/19720/2
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 )
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19720/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19720/1//COMMIT_MSG@11
PS1, Line 11: and usually fail
"and it usually fails" would be better.
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 08:03:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 )
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19720/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19720/1//COMMIT_MSG@11
PS1, Line 11: and it usually f
> "and it usually fails" would be better.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 09:21:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 )
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
Patch Set 2: Verified+1
Thank Michael and Daniel!
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 10:15:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19720 )
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
IMPALA-12055: Use jquery.min.js from local repo
Our website depends on
https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js
In some regions, it's pretty slow to get this file and it usually fails
at last.
This adds the file to the asf-site branch so the website can use a local
copy of it. Also bumps the jquery version to 3.5.1 to match the master
branch.
Tests:
- Verified the pages locally.
Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Reviewed-on: http://gerrit.cloudera.org:8080/19720
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
A js/jquery-3.5.1.min.js
M overview.html
7 files changed, 8 insertions(+), 10 deletions(-)
Approvals:
Daniel Becker: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 )
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 09:59:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 )
Change subject: IMPALA-12055: Use jquery.min.js from local repo
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8c4a9c2b9b64128e610a803363c2c5be6e57018
Gerrit-Change-Number: 19720
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Apr 2023 16:35:07 +0000
Gerrit-HasComments: No