You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/29 01:34:39 UTC
[GitHub] [incubator-tvm] jmorrill opened a new pull request #4785:
[FFI][Windows] Parse addition exception strings
jmorrill opened a new pull request #4785: [FFI][Windows] Parse addition exception strings
URL: https://github.com/apache/incubator-tvm/pull/4785
This is a continuation of #4780
This adds parsing for exceptions that are formatted like: "`AttributeError: relay.Op object has no attributed attrs`"
@soiferj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] jmorrill commented on issue #4785: [FFI][Windows]
Parse additional exception strings
Posted by GitBox <gi...@apache.org>.
jmorrill commented on issue #4785: [FFI][Windows] Parse additional exception strings
URL: https://github.com/apache/incubator-tvm/pull/4785#issuecomment-579897309
Clean fix was all you. I just did the clerical work.
Thanks man!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #4785: [FFI][Windows]
Parse additional exception strings
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #4785: [FFI][Windows] Parse additional exception strings
URL: https://github.com/apache/incubator-tvm/pull/4785#issuecomment-580071366
@soiferj if you have no other comment, please approve this change according to this doc: https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #4785: [FFI][Windows]
Parse additional exception strings
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #4785: [FFI][Windows] Parse additional exception strings
URL: https://github.com/apache/incubator-tvm/pull/4785#issuecomment-580344098
Thanks @jmorrill @soiferj This is merged now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] soiferj commented on issue #4785: [FFI][Windows]
Parse additional exception strings
Posted by GitBox <gi...@apache.org>.
soiferj commented on issue #4785: [FFI][Windows] Parse additional exception strings
URL: https://github.com/apache/incubator-tvm/pull/4785#issuecomment-580339270
@FrozenGene that’s how I approved the changes yesterday! Above my comment I see the message “soiferj approved these changes”. Feel free to check in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] FrozenGene merged pull request #4785:
[FFI][Windows] Parse additional exception strings
Posted by GitBox <gi...@apache.org>.
FrozenGene merged pull request #4785: [FFI][Windows] Parse additional exception strings
URL: https://github.com/apache/incubator-tvm/pull/4785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services