You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/03/31 14:31:47 UTC
[GitHub] [camel-k] gansheer opened a new pull request, #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
gansheer opened a new pull request, #4211:
URL: https://github.com/apache/camel-k/pull/4211
Fixes #1773
## Motivation
In Quarkus 3 / Camel 4, microprofile-metrics will be removed, and micrometer extension is its replacement.
The prometheus trait need to be modified to use the micrometer extension.
## Description
The micrometer extension replaces the microprofile extension, with the additional prometheus registry.
The e2e existing test is updated to be the most similar as possible in terms of metrics tested, but since micrometer offers less possibilities there are some adaptations.
**Release Note**
```release-note
Migrate prometheus trait from microprofile metrics to micrometer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4211:
URL: https://github.com/apache/camel-k/pull/4211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4211:
URL: https://github.com/apache/camel-k/pull/4211#issuecomment-1494255362
I think this is another case where we need to understand how to implement a trait leaving implementation details about runtime outside of Camel K: https://github.com/apache/camel-k/issues/4166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4211:
URL: https://github.com/apache/camel-k/pull/4211#issuecomment-1494268276
> I think this is another case where we need to understand how to implement a trait leaving implementation details about runtime outside of Camel K: #4166
I see, I will exclude it from this issue and document it in the documentation's example for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4211:
URL: https://github.com/apache/camel-k/pull/4211#issuecomment-1495435928
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4211:
URL: https://github.com/apache/camel-k/pull/4211#issuecomment-1492017615
The PR is in draft until I manage to fix the e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #4211: feat(trait): Migrate prometheus trait from microprofile metrics to micrometer
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4211:
URL: https://github.com/apache/camel-k/pull/4211#issuecomment-1494213040
I am trying to see if it is possible to add in the prometheus trait code the addition of a builder property `quarkus.micrometer.export.json.enabled=true` to ensure json api is available by default. I haven't manage to. Is there a way to do it while acting on the `e *Environment` object ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org