[GitHub] yestaro commented on issue #274: itemsExpand still not work, fix again

[GitBox <gi...@apache.org>]

yestaro commented on issue #274: itemsExpand still not work, fix again
URL: https://github.com/apache/royale-asjs/pull/274#issuecomment-415358189
 
 
   Hi Carlos
   
   the test example as below, just use j:HorizontalLayout in j:List, it output nothing
   ```xml
   <j:List id="list" percentWidth="100" height="100">  
       <j:beads>  
           <j:HorizontalLayout itemsExpand="true" />
       </j:beads>
       <j:dataProvider>
           <js:ArrayList id="avengersCharacters" source="[Iron Man, Hulk, Thor, Captain America]" />
       </j:dataProvider>
   </j:List>
   ```
   seems j:HGroup has fixed, but j:HorizontalLayout not.
   
   I look at **StyledLayoutBase.itemsHorizontalAlign** setter has logic `if(hostComponent)`
   but **itemsExpand** setter without `if(hostComponent)` that should be the problem
   original StyledLayoutBase.as itemsExpand setter as below.
   
   ```actionscript
   public function set itemsExpand(value:Boolean):void
           {
               if (_itemsExpand != value)
               {
                   _itemsExpand = value;
   				COMPILE::JS
                   {
   				if(_itemsExpand)
   				{
   					hostClassList.add("itemsExpand");
   				} else
   				{
   					hostClassList.remove("itemsExpand");
   				}
   				}
               }
           }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services