[GitHub] rabbah commented on a change in pull request #2689: first stage of support for dynamic invoker id assignment

[gi...@git.apache.org]

rabbah commented on a change in pull request #2689: first stage of support for dynamic invoker id assignment
URL: https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r140780199
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
 ##########
 @@ -87,6 +89,45 @@ object Invoker {
 
     val msgProvider = SpiLoader.get[MessagingProvider]
     val producer = msgProvider.getProducer(config, ec)
+
+    val proposedInvokerId = if (args.length == 1) { args(0).toInt } else { -1 }
+    val invokerName = sys.env.getOrElse("INVOKER_ASSIGNED_NAME", (() => {
 
 Review comment:
   you could also read this via whisk config - we've generally avoid reading anything from sys env in the past.
   it would fail if you start up the invoker without an id.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services