You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/08/02 16:43:37 UTC

[Bug 55347] New: [PATCH] Integrate XSSFTextBox with XSSFExcelExtractor, XSSFReader and XSSFEventBasedExcelExtractor

https://issues.apache.org/bugzilla/show_bug.cgi?id=55347

            Bug ID: 55347
           Summary: [PATCH] Integrate XSSFTextBox with XSSFExcelExtractor,
                    XSSFReader and XSSFEventBasedExcelExtractor
           Product: POI
           Version: 3.10-dev
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: tallison@mitre.org

Created attachment 30663
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30663&action=edit
Patch, initial draft

Follow on work to Darren Robert's patch of XSSFTextBox:
https://issues.apache.org/bugzilla/show_bug.cgi?id=55292

This patch integrates those updates into XSSFExcelExtractor and
XSSFEventBasedExcelExtractor. 

I'm posting the patch for review.  Two items that I'm not sure about:

1) I'm not actually streaming the textbox extraction in XSSFReader.  I followed
the model of headers and footers and used the regular XSSF-bean-based objects.

2) I had to change the XSSFDrawing() constructors to public.

Would appreciate any feedback on those issues or on the patch before I commit.

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 55347] [PATCH] Integrate XSSFTextBox with XSSFExcelExtractor, XSSFReader and XSSFEventBasedExcelExtractor

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55347

Darren Roberts <ro...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Darren Roberts <ro...@yahoo.com> ---
I've tried the patch out and it compiled for me, passed the unit tests and when
used with another test application successfully resolves this long standing
bug:

https://issues.apache.org/bugzilla/show_bug.cgi?id=45551

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 55347] [PATCH] Integrate XSSFTextBox with XSSFExcelExtractor, XSSFReader and XSSFEventBasedExcelExtractor

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55347

Tim Allison <ta...@mitre.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Tim Allison <ta...@mitre.org> ---
Committed r1511789.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org