You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Denis Chudov (Jira)" <ji...@apache.org> on 2022/06/07 09:49:00 UTC
[jira] [Commented] (IGNITE-17115) Add use of IGNITE_GET_METADATA_LOCALLY_ONLY from within SchemaManager
[ https://issues.apache.org/jira/browse/IGNITE-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550904#comment-17550904 ]
Denis Chudov commented on IGNITE-17115:
---------------------------------------
[~alapin] LGTM.
> Add use of IGNITE_GET_METADATA_LOCALLY_ONLY from within SchemaManager
> ---------------------------------------------------------------------
>
> Key: IGNITE-17115
> URL: https://issues.apache.org/jira/browse/IGNITE-17115
> Project: Ignite
> Issue Type: Task
> Reporter: Alexander Lapin
> Assignee: Alexander Lapin
> Priority: Major
> Labels: ignite-3
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During SchemaManager extraction from TableManager to explicit component latestSchemeVersion() losts its ability to use local configuration property instead of direct one if IGNITE_GET_METADATA_LOCALLY_ONLY is set to true.
> I've just copy-pasted IGNITE_GET_METADATA_LOCALLY_ONLY-aware direct proxy method from TableManager to SchemaManager
> {code:java}
> private <T extends ConfigurationProperty<?>> T directProxy(T property) {
> return getMetadataLocallyOnly ? property : ConfigurationUtil.directProxy(property);
> }{code}
> because, on the one hand IGNITE_GET_METADATA_LOCALLY_ONLY is itself temporary and thus directProxy doesn't worth the effort of moving to some additional level of abstraction, and on the other hand ConfigurationUtil.directProxy() is too common place to inline metadataLocallyOnly flag inside.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)