You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/23 05:35:08 UTC
[GitHub] [superset] john-bodley opened a new pull request #15319: fix: Capitalize time granularity weekdays
john-bodley opened a new pull request #15319:
URL: https://github.com/apache/superset/pull/15319
### SUMMARY
Ensures that the weekdays are capitalized for SQL granularities which is inline with Druid NoSQL.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### BEFORE
<img width="302" alt="Screen Shot 2021-06-22 at 9 59 37 PM" src="https://user-images.githubusercontent.com/4567245/123038629-e2a10480-d444-11eb-812f-6b0861d9a877.png">
#### AFTER
<img width="304" alt="Screen Shot 2021-06-22 at 10 34 20 PM" src="https://user-images.githubusercontent.com/4567245/123041347-4af1e500-d449-11eb-9de9-a1ba258804d2.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #15319: fix: Capitalize time granularity weekdays
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #15319:
URL: https://github.com/apache/superset/pull/15319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #15319: fix: Capitalize time granularity weekdays
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #15319:
URL: https://github.com/apache/superset/pull/15319#discussion_r656773374
##########
File path: superset/translations/messages.pot
##########
@@ -1894,19 +1894,19 @@ msgid "Year"
msgstr ""
#: superset/db_engine_specs/base.py:99
-msgid "Week starting sunday"
+msgid "Week starting Sunday"
msgstr ""
#: superset/db_engine_specs/base.py:100
-msgid "Week starting monday"
+msgid "Week starting Monday"
msgstr ""
#: superset/db_engine_specs/base.py:101
-msgid "Week ending saturday"
+msgid "Week ending Saturday"
msgstr ""
#: superset/db_engine_specs/base.py:102
-msgid "Week_ending sunday"
+msgid "Week ending Sunday"
Review comment:
Previous underscore typo.
##########
File path: superset/translations/ko/LC_MESSAGES/messages.po
##########
@@ -1845,19 +1845,19 @@ msgid "Year"
msgstr "년"
#: superset/db_engine_specs/base.py:95
-msgid "Week starting sunday"
+msgid "Week starting Sunday"
msgstr ""
#: superset/db_engine_specs/base.py:96
-msgid "Week starting monday"
+msgid "Week starting Monday"
msgstr ""
#: superset/db_engine_specs/base.py:97
-msgid "Week ending saturday"
+msgid "Week ending Saturday"
msgstr ""
#: superset/db_engine_specs/base.py:98
-msgid "Week_ending sunday"
+msgid "Week ending Sunday"
Review comment:
Previous underscore typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15319: fix: Capitalize time granularity weekdays
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15319:
URL: https://github.com/apache/superset/pull/15319#issuecomment-866574864
# [Codecov](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15319](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b53fbdb) into [master](https://codecov.io/gh/apache/superset/commit/c211f7df8e5d3ebe0d0424016354f27aef5882aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c211f7d) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head b53fbdb differs from pull request most recent head bb45da8. Consider uploading reports for the commit bb45da8 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15319 +/- ##
==========================================
- Coverage 77.23% 77.07% -0.17%
==========================================
Files 973 973
Lines 50478 50478
Branches 6182 6182
==========================================
- Hits 38985 38904 -81
- Misses 11287 11368 +81
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `81.70% <ø> (+<0.01%)` | :arrow_up: |
| presto | `81.40% <ø> (ø)` | |
| python | `81.92% <ø> (-0.31%)` | :arrow_down: |
| sqlite | `81.33% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.37% <ø> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `83.95% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-4.29%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.23% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.10% <0.00%> (-0.44%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.63% <0.00%> (-0.24%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c211f7d...bb45da8](https://codecov.io/gh/apache/superset/pull/15319?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org