You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/09 15:57:14 UTC
[GitHub] [incubator-devlake] likyh opened a new pull request, #4162: fix: fix jenkins upgrade
likyh opened a new pull request, #4162:
URL: https://github.com/apache/incubator-devlake/pull/4162
### Summary
fix jenkins upgrade.
V100 bp with transformation may like this:
```
{
"name": "TEST_PROJECT_2-BLUEPRINT",
"mode": "NORMAL",
"enable": true,
"cronConfig": "0 0 * * *",
"isManual": false,
"skipOnFail": false,
"labels": [],
"settings": {"connections":[{"connectionId":1,"plugin":"jenkins","scope":[{"entities":["CICD"],"options":{},"transformation":{"deploymentPattern":"","productionPattern":""}}]}],"version":"1.0.0"},
"createdAt": "2022-12-12T08:36:38.079Z",
"updatedAt": "2022-12-13T08:31:51.696Z"
}
```
So add some fix for upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4162: fix: fix jenkins upgrade
Posted by GitBox <gi...@apache.org>.
mintsweet commented on code in PR #4162:
URL: https://github.com/apache/incubator-devlake/pull/4162#discussion_r1065280110
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -64,7 +64,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
name: plugin.name,
connectionId: cs.connectionId,
entities: plugin.entities,
- selectedEntites: cs.scopes?.[0].entities ?? [],
+ selectedEntites: cs.scopes.length > 0 ? cs.scopes[0].entities : [],
Review Comment:
This is because you set the scope to [].
when scope does not exist `cs.scope?.[0]?.entities ?? [] === []`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4162: fix: fix jenkins upgrade
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #4162:
URL: https://github.com/apache/incubator-devlake/pull/4162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4162: fix: fix jenkins upgrade
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #4162:
URL: https://github.com/apache/incubator-devlake/pull/4162#discussion_r1064801496
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -64,7 +64,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
name: plugin.name,
connectionId: cs.connectionId,
entities: plugin.entities,
- selectedEntites: cs.scopes?.[0].entities ?? [],
+ selectedEntites: cs.scopes.length > 0 ? cs.scopes[0].entities : [],
Review Comment:
they are not equal when cs.scopes is `[]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org