You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/06/23 08:45:28 UTC
[I] [CI][Dev] Fix shellcheck errors in the ci/scripts/install_gcs_testbench.sh [arrow]
hiroyuki-sato opened a new issue, #46881:
URL: https://github.com/apache/arrow/issues/46881
### Describe the enhancement requested
This is the sub issue #44748.
* SC2068: Double quote array expansions to avoid re-splitting elements.
* SC2154: default is referenced but not assigned.
* SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
* SC2223: This default assignment may cause DoS due to globbing. Quote it.
* SC2309: -eq treats this as a variable. Use = to compare as string (or expand explicitly with $var).
```
In ci/scripts/install_gcs_testbench.sh line 38:
if [[ "${version}" -eq "default" ]]; then
^-------^ SC2154 (warning): default is referenced but not assigned.
^-------^ SC2309 (warning): -eq treats this as a variable. Use = to compare as string (or expand explicitly with $var).
In ci/scripts/install_gcs_testbench.sh line 43:
: ${PIPX_BASE_PYTHON:=$(which python3)}
^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
In ci/scripts/install_gcs_testbench.sh line 45:
: ${PIPX_PYTHON:=${PIPX_BASE_PYTHON:-$(which python3)}}
^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
In ci/scripts/install_gcs_testbench.sh line 50:
pipx_flags=(--verbose --python ${PIPX_PYTHON})
^------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
In ci/scripts/install_gcs_testbench.sh line 58:
${PIPX_BASE_PYTHON} -m pipx install ${pipx_flags[@]} \
^--------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
https://www.shellcheck.net/wiki/SC2154 -- default is referenced but not ass...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
```
### Component(s)
Continuous Integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][Dev] Fix shellcheck errors in the ci/scripts/install_gcs_testbench.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #46881: [CI][Dev] Fix shellcheck errors in the ci/scripts/install_gcs_testbench.sh
URL: https://github.com/apache/arrow/issues/46881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][Dev] Fix shellcheck errors in the ci/scripts/install_gcs_testbench.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #46881:
URL: https://github.com/apache/arrow/issues/46881#issuecomment-2998373048
Issue resolved by pull request 46882
https://github.com/apache/arrow/pull/46882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org