[GitHub] [samza] atoomula commented on a change in pull request #1148: SAMZA-2313: Adding validation for Samza Sql statements.

[GitBox <gi...@apache.org>]

atoomula commented on a change in pull request #1148: SAMZA-2313: Adding validation for Samza Sql statements.
URL: https://github.com/apache/samza/pull/1148#discussion_r320462408
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java
 ##########
 @@ -0,0 +1,279 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements.  See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership.  The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License.  You may obtain a copy of the License at
+*
+*   http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
+* software distributed under the License is distributed on an
+* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+* KIND, either express or implied.  See the License for the
+* specific language governing permissions and limitations
+* under the License.
+*/
+
+package org.apache.samza.sql.planner;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.Scanner;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+import org.apache.calcite.rel.RelRoot;
+import org.apache.calcite.rel.logical.LogicalProject;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactoryImpl;
+import org.apache.calcite.rel.type.RelDataTypeField;
+import org.apache.calcite.rel.type.RelRecordType;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.samza.SamzaException;
+import org.apache.samza.config.Config;
+import org.apache.samza.sql.data.SamzaSqlRelMessage;
+import org.apache.samza.sql.dsl.SamzaSqlDslConverter;
+import org.apache.samza.sql.interfaces.RelSchemaProvider;
+import org.apache.samza.sql.interfaces.SamzaSqlJavaTypeFactoryImpl;
+import org.apache.samza.sql.runner.SamzaSqlApplicationConfig;
+import org.apache.samza.sql.util.SamzaSqlQueryParser;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * SamzaSqlValidator that uses calcite engine to convert the sql query to relational graph and validates the query
+ * including the output.
+ */
+public class SamzaSqlValidator {
+  private static final Logger LOG = LoggerFactory.getLogger(SamzaSqlValidator.class);
+
+  private final Config config;
+
+  public SamzaSqlValidator(Config config) {
+    this.config = config;
+  }
+
+  /**
+   * Validate a list of sql statements
+   * @param sqlStmts list of sql statements
+   * @throws SamzaSqlValidatorException
+   */
+  public void validate(List<String> sqlStmts) throws SamzaSqlValidatorException {
+    SamzaSqlApplicationConfig sqlConfig = SamzaSqlDslConverter.getSqlConfig(sqlStmts, config);
+    QueryPlanner planner = SamzaSqlDslConverter.getQueryPlanner(sqlConfig);
+
+    for (String sql: sqlStmts) {
+      // we always pass only select query to the planner for samza sql. The reason is that samza sql supports
+      // schema evolution where source and destination could up to an extent have independent schema evolution while
+      // calcite expects strict conformance of the destination schema with that of the fields in the select query.
+      SamzaSqlQueryParser.QueryInfo qinfo = SamzaSqlQueryParser.parseQuery(sql);
+      RelRoot relRoot;
+      try {
+        relRoot = planner.plan(qinfo.getSelectQuery());
+      } catch (SamzaException e) {
+        throw new SamzaSqlValidatorException("Calcite planning for sql failed.", e);
+      }
+
+      // Now that we have logical plan, validate different aspects.
+      validate(relRoot, qinfo, sqlConfig);
+    }
+  }
+
+  protected void validate(RelRoot relRoot, SamzaSqlQueryParser.QueryInfo qinfo, SamzaSqlApplicationConfig sqlConfig)
+      throws SamzaSqlValidatorException {
+    // Validate select fields (including Udf return types) with output schema
+    validateOutput(relRoot, sqlConfig.getRelSchemaProviders().get(qinfo.getSink()));
+
+    // TODO:
+    //  1. Validate Udf arguments.
+    //  2. Validate operators. These are the operators that are supported by Calcite but not by Samza Sql.
+    //     Eg: LogicalAggregate is not supported by Samza Sql.
 
 Review comment:
   Changed to "LogicalAggregate with sum function is not supported by Samza Sql."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services