You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Marco Lotz (Jira)" <ji...@apache.org> on 2021/02/09 13:32:00 UTC
[jira] [Commented] (KAFKA-5146) Kafka Streams: remove compile
dependency on connect-json
[ https://issues.apache.org/jira/browse/KAFKA-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281789#comment-17281789 ]
Marco Lotz commented on KAFKA-5146:
-----------------------------------
[~mjsax] I recall we had a similar problem when updating to Java 11. Also, shipping the example with the production code, as everyone seems to agree, is sub-optimal.
Kafka contains right now a module called "[examples|https://github.com/apache/kafka/tree/trunk/examples]", as [~guozhang] mentioned. If nobody strongly disagrees, I can send a PR moving this section of code there and removing the dependency. I can move it a package called "streams.examples" inside the "examples" module for example. Also, seems that I will have to update the Readme of the examples module - since although the package name is plural, currently there's only one example there.
The example code itself was quite useful when I was onboarding some members - so I would suggest not to remove it.
> Kafka Streams: remove compile dependency on connect-json
> --------------------------------------------------------
>
> Key: KAFKA-5146
> URL: https://issues.apache.org/jira/browse/KAFKA-5146
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.1.0, 0.10.2.0, 0.10.2.1
> Reporter: Michael G. Noll
> Priority: Minor
>
> We currently have a compile-dependency on `connect-json`:
> {code}
> <dependency>
> <groupId>org.apache.kafka</groupId>
> <artifactId>connect-json</artifactId>
> <version>0.10.2.0</version>
> <scope>compile</scope>
> </dependency>
> {code}
> The snippet above is from the generated POM of Kafka Streams as of 0.10.2.0 release.
> AFAICT the only reason for that is because the Kafka Streams *examples* showcase some JSON processing, but that’s it.
> First and foremost, we should remove the connect-json dependency, and also figure out a way to set up / structure the examples so we that we can continue showcasing JSON support. Alternatively, we could consider removing the JSON example (but I don't like that, personally).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)