You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/04 09:36:44 UTC
[GitHub] [zeppelin] EricGao888 opened a new pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
EricGao888 opened a new pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130
### What is this PR for?
* Enable extension of flexmark in markdown interpreter
### What type of PR is it?
Improvement
### Todos
* [ ] - Make emoji auto-scale according to the size of text
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5266
### How should this be tested?
* Create a cell of markdown type, set the interpreter to be flexmark and type in an emoji code, e.g. :joy:
### Screenshots (if appropriate)
### Questions:
* None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-855538308
@EricGao888 You can use `download-maven-plugin` to download these images and put them in the zeppelin-web module.
See the example here https://github.com/apache/zeppelin/blob/master/spark/interpreter/pom.xml#L361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] EricGao888 commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856538713
> > > Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository.
> >
> >
> > I found that unicode can be used instead of images for emojis. I think it's a better way.
>
> Unicode should be sufficient. It would be nice if you would update your image.
>
> LGTM
Sure, will update the images just in case the unicode stuff breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856470547
> > Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository.
>
> I found that unicode can be used instead of images for emojis. I think it's a better way.
Unicode should be sufficient. It would be nice if you would update your image.
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-859326448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] EricGao888 commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856405185
> Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository.
I found that unicode can be used instead of images for emojis. I think it's a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] EricGao888 commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-855535278
> Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository.
Good suggestion, may I ask how I can download the emojis to the web assets folder during the build process? BTW, I found a link to https://www.webfx.com/tools/emoji-cheat-sheet/ in flexmark docs where I got those images. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-854612660
Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org