You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/14 23:35:25 UTC
[GitHub] [superset] betodealmeida commented on a change in pull request #14147: feat: Setup DB Connection Error messages config
betodealmeida commented on a change in pull request #14147:
URL: https://github.com/apache/superset/pull/14147#discussion_r613651510
##########
File path: superset/databases/commands/exceptions.py
##########
@@ -131,7 +134,7 @@ class DatabaseTestConnectionDriverError(CommandInvalidError):
class DatabaseTestConnectionUnexpectedError(CommandInvalidError):
- message = _("Unexpected error occurred, please check your logs for details")
+ message = _(TEXT_DATABASE_CONN["database_test_connection_unexpected"])
Review comment:
I'm not super familiar with gettext, but I think you need to move the `__()` call to `superset/config.py` where the string is defined, you can't use it with variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org