You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/06 02:43:28 UTC

Review Request 41960: Added the Docker URI fetcher plugin interface.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41960/
-----------------------------------------------------------

Review request for mesos, Timothy Chen and Vinod Kone.


Bugs: MESOS-4296
    https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
-------

Added the Docker URI fetcher plugin interface. See the motivation in the ticket.

This patch just introduces the interface. The implementation will be added in the subsequent patches.


Diffs
-----

  src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d 
  src/uri/fetcher.hpp d5182a51809b901b5c22dc66cd48e0068caf89a0 
  src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5 
  src/uri/fetchers/docker.hpp PRE-CREATION 
  src/uri/fetchers/docker.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41960/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 41960: Added the Docker URI fetcher plugin interface.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41960/#review113541
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Jan. 6, 2016, 1:43 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41960/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 1:43 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Vinod Kone.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the Docker URI fetcher plugin interface. See the motivation in the ticket.
> 
> This patch just introduces the interface. The implementation will be added in the subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d 
>   src/uri/fetcher.hpp d5182a51809b901b5c22dc66cd48e0068caf89a0 
>   src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5 
>   src/uri/fetchers/docker.hpp PRE-CREATION 
>   src/uri/fetchers/docker.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41960/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>