[jira] [Commented] (BEAM-2581) KinesisClientProvider interface needs to be public

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082248#comment-16082248 ] 

ASF GitHub Bot commented on BEAM-2581:
--------------------------------------

GitHub user nawaidshamim opened a pull request:

    https://github.com/apache/beam/pull/3540

    BEAM-2581: KinesisClientProvider interface needs to be public

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nawaidshamim/beam KinesisClientProvider-Interface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3540
    
----
commit 3395b2c489d0ee7fb8da090aea0a87377702f760
Author: Nawaid Shamim <na...@bbc.co.uk>
Date:   2017-07-11T14:03:25Z

    BEAM-2581: KinesisClientProvider interface needs to be public

----


> KinesisClientProvider interface needs to be public
> --------------------------------------------------
>
>                 Key: BEAM-2581
>                 URL: https://issues.apache.org/jira/browse/BEAM-2581
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.0.0
>            Reporter: Nawaid Shamim
>            Assignee: Davor Bonaci
>            Priority: Minor
>
> Using Beam to read from kinesis stream. `KinesisIO` provides two overloaded methods to provided AWS credential or AWSKinesisClient - `withClientProvider` as described on [here](https://beam.apache.org/documentation/sdks/javadoc/2.0.0/)
>  public class MyCustomKinesisClientProvider implements KinesisClientProvider {
>    {@literal @}Override
>    public AmazonKinesis get() {
>      // set up your client here
>    }
>  }
>  
> Usage is pretty straightforward:
> {code}
> {noformat}
> There's also possibility to start reading using arbitrary point in time - in this case you need to provide Instant object:
>  p.apply(KinesisIO.read()
>      .from("streamName", instant)
>      .withClientProvider(new KinesisClientProvider() {
>                         @Override
>                         public AmazonKinesis get() {
>                             return null;
>                         }
>       })
>   .apply( ... ) // other transformations
> {code}
> The above code requires org.apache.beam.sdk.io.kinesis.KinesisClientProvider interface to be public.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)