You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/18 18:16:41 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #5264: sched: Define SMP_NCPUS to 1 in no SMP case

Ouss4 commented on a change in pull request #5264:
URL: https://github.com/apache/incubator-nuttx/pull/5264#discussion_r787030552



##########
File path: arch/xtensa/src/esp32/esp32_irq.c
##########
@@ -595,11 +580,7 @@ void up_enable_irq(int irq)
   int cpuint = IRQ_GETCPUINT(g_irqmap[irq]);
 
   DEBUGASSERT(cpuint >= 0 && cpuint <= ESP32_CPUINT_MAX);
-#ifdef CONFIG_SMP
   DEBUGASSERT(cpu >= 0 && cpu <= CONFIG_SMP_NCPUS);

Review comment:
       Yes, you are right.  `cpu` here is used to index the CPU interrupts array.  @xiaoxiang781216 can you please apply @gustavonihei's suggestion and also fix the same assertion in `up_disable_irq` in line 532.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org