You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "hboutemy (via GitHub)" <gi...@apache.org> on 2023/03/11 18:50:00 UTC
[GitHub] [commons-statistics] hboutemy opened a new pull request, #42: remove entry adding non-reproducible entry
hboutemy opened a new pull request, #42:
URL: https://github.com/apache/commons-statistics/pull/42
see test done for 1.0 release https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/commons/statistics/README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] hboutemy commented on pull request #42: remove entry adding non-reproducible entry
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #42:
URL: https://github.com/apache/commons-statistics/pull/42#issuecomment-1465041478
it could probably work when building from Git, but when building from official source release archive, Git won't be there to inject the commit hash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] aherbert merged pull request #42: remove entry adding non-reproducible entry
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert merged PR #42:
URL: https://github.com/apache/commons-statistics/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] aherbert commented on pull request #42: remove entry adding non-reproducible entry
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on PR #42:
URL: https://github.com/apache/commons-statistics/pull/42#issuecomment-1464991200
Would it pass the reproducible build if the timestamp was dropped and the repo build number left in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] codecov-commenter commented on pull request #42: remove entry adding non-reproducible entry
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #42:
URL: https://github.com/apache/commons-statistics/pull/42#issuecomment-1464982444
## [Codecov](https://codecov.io/gh/apache/commons-statistics/pull/42?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#42](https://codecov.io/gh/apache/commons-statistics/pull/42?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b4f8b5) into [master](https://codecov.io/gh/apache/commons-statistics/commit/cf0ba7bcc5a59ea747a53baefe267a310b21cfcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf0ba7b) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
Coverage 99.89% 99.89%
Complexity 1526 1526
=========================================
Files 61 61
Lines 3925 3925
Branches 651 651
=========================================
Hits 3921 3921
Misses 2 2
Partials 2 2
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] ebourg commented on pull request #42: remove entry adding non-reproducible entry
Posted by "ebourg (via GitHub)" <gi...@apache.org>.
ebourg commented on PR #42:
URL: https://github.com/apache/commons-statistics/pull/42#issuecomment-1465773494
+1, there is no point adding the commit hash in the manifest, because once the build is reproducible, there is no ambiguity about which commit generated the binary, this info is implicitly carried by the version number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org