You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/01/21 18:34:26 UTC

[PR] [SPARK-55115][INFRA] Install both Java 8 and Java 17 in release Docker image [spark]

cloud-fan opened a new pull request, #53891:
URL: https://github.com/apache/spark/pull/53891

   ### What changes were proposed in this pull request?
   
   This updates the release manager Docker image to include both Java 8 and Java 17, enabling builds for all active Spark branches:
   - Spark < 4.0: requires Java 8
   - Spark >= 4.0: requires Java 17
   
   ### Changes:
   - Add `openjdk-8-jdk-headless` alongside existing Java 17
   - Set up architecture-aware Java paths in `/etc/profile.d/java.sh` (works on both amd64 and arm64)
   - Export `JAVA8_HOME`, `JAVA17_HOME`, and `JAVA_HOME` environment variables
   
   ### Why are the changes needed?
   
   To support releasing all active Spark versions (3.5, 4.0, 4.1, 4.2) from a single Docker image. The release scripts will automatically select the appropriate Java version based on the Spark version being released.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. This only affects the release infrastructure.
   
   ### How was this patch tested?
   
   Manual testing by building the Docker image and verifying both Java versions are installed.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes. cursor 2.3.41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55115][INFRA] Install both Java 8 and Java 17 in release Docker image [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #53891:
URL: https://github.com/apache/spark/pull/53891#issuecomment-3782347944

   This only fixes java version but not python version, switching to https://github.com/apache/spark/pull/53905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55115][INFRA] Install both Java 8 and Java 17 in release Docker image [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53891:
URL: https://github.com/apache/spark/pull/53891#issuecomment-3780468823

   ## JIRA Issue Information
   
   === Improvement SPARK-55115 ===
   Summary: Use master branch's Dockerfile for release builds
   Assignee: None
   Status: Open
   Affected: ["4.2.0"]
   
   ---
   *This comment was automatically generated by GitHub Actions*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55115][INFRA] Install both Java 8 and Java 17 in release Docker image [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #53891: [SPARK-55115][INFRA] Install both Java 8 and Java 17 in release Docker image
URL: https://github.com/apache/spark/pull/53891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org