[jira] [Commented] (DRILL-1282) Add read and write support for Parquet v2

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445722#comment-17445722 ] 

ASF GitHub Bot commented on DRILL-1282:
---------------------------------------

dzamo commented on a change in pull request #2351:
URL: https://github.com/apache/drill/pull/2351#discussion_r752001140



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
##########
@@ -78,6 +80,8 @@
 
 public class ParquetFormatPlugin implements FormatPlugin {
 
+  public static final String[] PARQUET_VERSIONS = {"PARQUET_1_0", "PARQUET_2_0"};

Review comment:
       @vdiravka I followed `ParquetProperties#WriterVersion`, that's where `PARQUET_1_0` and `PARQUET_2_0` come from.  I agree it's clunky, but on the other hand I did not have introduce any new version format strings or case statements.  Which do you think is preferable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add read and write support for Parquet v2
> -----------------------------------------
>
>                 Key: DRILL-1282
>                 URL: https://issues.apache.org/jira/browse/DRILL-1282
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Parquet
>            Reporter: Jacques Nadeau
>            Assignee: James Turton
>            Priority: Minor
>             Fix For: Future
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)