You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <jl...@apache.org> on 2022/02/03 09:02:36 UTC
Re: [ofbiz-framework] branch trunk updated: Improved: no functional change, adds a BuildBot badge (INFRA-22807)
Le 03/02/2022 à 09:54, jleroux@apache.org a écrit :
> Improved: no functional change, adds a BuildBot badge (INFRA-22807)
>
> It works locally (once you have installed Ruby, asciidoctor and
> asciidoctor-diagram). CHecking that it's also OK on BuildBot, let's see result
> athttps://nightlies.apache.org/ofbiz/trunk/readme/html5/
> ---
> README.adoc | 1 +
> .../ofbiz/widget/model/ModelFormFieldBuilder.java | 107 +++++++++------------
> 2 files changed, 47 insertions(+), 61 deletions(-)
Revert in model/ModelFormFieldBuilder.java should not have been part of previous commit but another commit, my bad.
Anyway at least things can get ahead now...
Re: [ofbiz-framework] branch trunk updated: Improved: no functional change, adds a BuildBot badge (INFRA-22807)
Posted by Jacques Le Roux <ja...@les7arts.com>.
Actually that was my bad to commit my local changes that helped me to get ahead.
I should have kept them local until you resolved the issue. BTW I did not change R22.
Please do as you prefer:
* don't wait for using SDK 11, fix the issue in both using your local code w/o reverting
* revert only R22 and wait for JDK 11 to commit both
I vaguely feel another option is possible, but my mind seems to like to hide it to "me". Weird isn't, intuition is not always right anyway. I guess
it's hypoglycaemic :)
HTH
Jacques
Le 03/02/2022 à 10:09, Nicolas Malin a écrit :
> No worries Jacques, I revert my local fix commit, you gone faster than me.
>
> What can I do for help, to escape any collision with you ?
>
> Nicolas
>
> On 03/02/2022 10:02, Jacques Le Roux wrote:
>> Le 03/02/2022 à 09:54,jleroux@apache.org a écrit :
>>> Improved: no functional change, adds a BuildBot badge (INFRA-22807)
>>> It works locally (once you have installed Ruby, asciidoctor
>>> and
>>> asciidoctor-diagram). CHecking that it's also OK on BuildBot,
>>> let's see result
>>> athttps://nightlies.apache.org/ofbiz/trunk/readme/html5/
>>> ---
>>> README.adoc | 1 +
>>> .../ofbiz/widget/model/ModelFormFieldBuilder.java | 107
>>> +++++++++------------
>>> 2 files changed, 47 insertions(+), 61 deletions(-)
>> Revert in model/ModelFormFieldBuilder.java should not have been part
>> of previous commit but another commit, my bad.
>>
>> Anyway at least things can get ahead now...
>>
>>
Re: [ofbiz-framework] branch trunk updated: Improved: no functional change, adds a BuildBot badge (INFRA-22807)
Posted by Nicolas Malin <ni...@nereide.fr>.
No worries Jacques, I revert my local fix commit, you gone faster than me.
What can I do for help, to escape any collision with you ?
Nicolas
On 03/02/2022 10:02, Jacques Le Roux wrote:
> Le 03/02/2022 à 09:54, jleroux@apache.org a écrit :
>> Improved: no functional change, adds a BuildBot badge (INFRA-22807)
>> It works locally (once you have installed Ruby, asciidoctor
>> and
>> asciidoctor-diagram). CHecking that it's also OK on BuildBot,
>> let's see result
>> athttps://nightlies.apache.org/ofbiz/trunk/readme/html5/
>> ---
>> README.adoc | 1 +
>> .../ofbiz/widget/model/ModelFormFieldBuilder.java | 107
>> +++++++++------------
>> 2 files changed, 47 insertions(+), 61 deletions(-)
> Revert in model/ModelFormFieldBuilder.java should not have been part
> of previous commit but another commit, my bad.
>
> Anyway at least things can get ahead now...
>
>