You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/24 12:38:03 UTC
[GitHub] [rocketmq-operator] caigy commented on a change in pull request #61: [ISSUEE 60] Add features to the broker and nameserver
caigy commented on a change in pull request #61:
URL: https://github.com/apache/rocketmq-operator/pull/61#discussion_r834260789
##########
File path: pkg/controller/broker/broker_controller.go
##########
@@ -401,8 +401,15 @@ func (r *ReconcileBroker) getBrokerStatefulSet(broker *rocketmqv1alpha1.Broker,
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: ls,
+ Annotations: broker.Spec.PodAnnotations,
},
Spec: corev1.PodSpec{
+ Affinity: broker.Spec.Affinity,
+ SecurityContext: broker.Spec.SecurityContext,
+ ImagePullSecrets: broker.Spec.ImagePullSecrets,
+ Tolerations: broker.Spec.Tolerations,
+ NodeSelector: broker.Spec.NodeSelector,
+ PriorityClassName: broker.Spec.PriorityClassName,
Review comment:
+1 This pr added features that help enrich operator, hope that corresponding null check would be supplemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org