You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "xu1009 (via GitHub)" <gi...@apache.org> on 2023/04/27 08:36:30 UTC
[GitHub] [skywalking-java] xu1009 opened a new pull request, #517: support jetty server work thread pool metric monitor
xu1009 opened a new pull request, #517:
URL: https://github.com/apache/skywalking-java/pull/517
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. https://github.com/apache/skywalking/issues/10736.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #517: support jetty server work thread pool metric monitor
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #517:
URL: https://github.com/apache/skywalking-java/pull/517#discussion_r1182208942
##########
.github/workflows/plugins-jdk17-test.0.yaml:
##########
@@ -57,6 +57,7 @@ jobs:
case:
- jdk17-with-gson-scenario
- resttemplate-6.x-scenario
+ - jetty-thread-pool-scenario
Review Comment:
```suggestion
- jetty-thread-pool-scenario
- jetty-11.x-thread-pool-scenario
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #517: support jetty server work thread pool metric monitor
Posted by "xu1009 (via GitHub)" <gi...@apache.org>.
xu1009 commented on PR #517:
URL: https://github.com/apache/skywalking-java/pull/517#issuecomment-1525205586
ok，i write another test for 11, have fun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #517: support jetty server work thread pool metric monitor
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #517:
URL: https://github.com/apache/skywalking-java/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #517: support jetty server work thread pool metric monitor
Posted by "xu1009 (via GitHub)" <gi...@apache.org>.
xu1009 commented on PR #517:
URL: https://github.com/apache/skywalking-java/pull/517#issuecomment-1525150466
the plugin supports jetty 11，but jetty 11 example is different with lower version, should i write new scenario test for 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #517: support jetty server work thread pool metric monitor
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #517:
URL: https://github.com/apache/skywalking-java/pull/517#discussion_r1182210051
##########
.github/workflows/plugins-jdk17-test.0.yaml:
##########
@@ -57,6 +57,7 @@ jobs:
case:
- jdk17-with-gson-scenario
- resttemplate-6.x-scenario
+ - jetty-thread-pool-scenario
Review Comment:
@xu1009 I believe the both cases should be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #517: support jetty server work thread pool metric monitor
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #517:
URL: https://github.com/apache/skywalking-java/pull/517#issuecomment-1525170416
Yes, if the test app can't be built simply though maven version, you have to write a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #517: support jetty server work thread pool metric monitor
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #517:
URL: https://github.com/apache/skywalking-java/pull/517#issuecomment-1525184053
BTW, I am on vacation already. I will be back on May 3rd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org