You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Suraj Khurana <su...@hotwax.co> on 2020/05/30 16:25:00 UTC
IMPROVEMENT: Checkstyle formatting issues
Hello Devs,
Hope you are doing good !!
Currently, there are many checkstyle issues in code base which are due to
formatting best practices, like indentation, using spaces before/after
symbols etc.
We can solve many thousands of such issues by correcting all such
occurrences. Please share your thoughts on this.
A known thing is that we will lose the last history of such codebase while
doing this re-factoring.
Any other ideas to solve the problem are most welcome.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Suraj Khurana <su...@hotwax.co>.
Thanks everyone for your inputs.
Here [1] is the ticket created for the same.
[1] : https://issues.apache.org/jira/browse/OFBIZ-11805
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Wed, Jun 3, 2020 at 7:55 PM Mridul Pathak <
mridul.pathak@hotwaxsystems.com> wrote:
> +1
>
> Thanks.
> --
> Mridul Pathak
>
>
> > On 30-May-2020, at 9:55 PM, Suraj Khurana <su...@hotwax.co>
> wrote:
> >
> > Hello Devs,
> >
> > Hope you are doing good !!
> >
> > Currently, there are many checkstyle issues in code base which are due to
> > formatting best practices, like indentation, using spaces before/after
> > symbols etc.
> >
> > We can solve many thousands of such issues by correcting all such
> > occurrences. Please share your thoughts on this.
> >
> > A known thing is that we will lose the last history of such codebase
> while
> > doing this re-factoring.
> >
> > Any other ideas to solve the problem are most welcome.
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
>
>
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Mridul Pathak <mr...@hotwaxsystems.com>.
+1
Thanks.
--
Mridul Pathak
> On 30-May-2020, at 9:55 PM, Suraj Khurana <su...@hotwax.co> wrote:
>
> Hello Devs,
>
> Hope you are doing good !!
>
> Currently, there are many checkstyle issues in code base which are due to
> formatting best practices, like indentation, using spaces before/after
> symbols etc.
>
> We can solve many thousands of such issues by correcting all such
> occurrences. Please share your thoughts on this.
>
> A known thing is that we will lose the last history of such codebase while
> doing this re-factoring.
>
> Any other ideas to solve the problem are most welcome.
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Aditya Sharma <ad...@apache.org>.
+1
Thanks and regards,
Aditya Sharma
On Mon, Jun 1, 2020 at 5:09 PM Suraj Khurana <su...@hotwax.co>
wrote:
> Hello Michael,
>
> Just the very last commit on that particular line that we check while
> annotating. Nothing else. As Jacques mentioned most of the time the history
> can be rebuilt with blame using lines around.
>
> --
> Best Regards,
> Suraj Khurana
> SENIOR TECHNICAL CONSULTANT
> mobile: +91 9669750002
> email: suraj.khurana@hotwax.co
> *www.hotwax.co <http://www.hotwax.co/>*
>
>
> On Mon, Jun 1, 2020 at 2:43 PM Michael Brohl <mi...@ecomify.de>
> wrote:
>
> > Hi Suraj,
> >
> > +1 for the refactoring in general. What history do we lose while
> > refactoring?
> >
> > Thanks,
> >
> > Michael
> >
> >
> > Am 30.05.20 um 18:25 schrieb Suraj Khurana:
> > > Hello Devs,
> > >
> > > Hope you are doing good !!
> > >
> > > Currently, there are many checkstyle issues in code base which are due
> to
> > > formatting best practices, like indentation, using spaces before/after
> > > symbols etc.
> > >
> > > We can solve many thousands of such issues by correcting all such
> > > occurrences. Please share your thoughts on this.
> > >
> > > A known thing is that we will lose the last history of such codebase
> > while
> > > doing this re-factoring.
> > >
> > > Any other ideas to solve the problem are most welcome.
> > > --
> > > Best Regards,
> > > Suraj Khurana
> > > Senior Technical Consultant
> > >
> >
> >
>
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Suraj Khurana <su...@hotwax.co>.
Hello Michael,
Just the very last commit on that particular line that we check while
annotating. Nothing else. As Jacques mentioned most of the time the history
can be rebuilt with blame using lines around.
--
Best Regards,
Suraj Khurana
SENIOR TECHNICAL CONSULTANT
mobile: +91 9669750002
email: suraj.khurana@hotwax.co
*www.hotwax.co <http://www.hotwax.co/>*
On Mon, Jun 1, 2020 at 2:43 PM Michael Brohl <mi...@ecomify.de>
wrote:
> Hi Suraj,
>
> +1 for the refactoring in general. What history do we lose while
> refactoring?
>
> Thanks,
>
> Michael
>
>
> Am 30.05.20 um 18:25 schrieb Suraj Khurana:
> > Hello Devs,
> >
> > Hope you are doing good !!
> >
> > Currently, there are many checkstyle issues in code base which are due to
> > formatting best practices, like indentation, using spaces before/after
> > symbols etc.
> >
> > We can solve many thousands of such issues by correcting all such
> > occurrences. Please share your thoughts on this.
> >
> > A known thing is that we will lose the last history of such codebase
> while
> > doing this re-factoring.
> >
> > Any other ideas to solve the problem are most welcome.
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
>
>
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Michael,
Information from Git history and blame mostly, I'd say
Jacques
Le 01/06/2020 à 11:13, Michael Brohl a écrit :
> Hi Suraj,
>
> +1 for the refactoring in general. What history do we lose while refactoring?
>
> Thanks,
>
> Michael
>
>
> Am 30.05.20 um 18:25 schrieb Suraj Khurana:
>> Hello Devs,
>>
>> Hope you are doing good !!
>>
>> Currently, there are many checkstyle issues in code base which are due to
>> formatting best practices, like indentation, using spaces before/after
>> symbols etc.
>>
>> We can solve many thousands of such issues by correcting all such
>> occurrences. Please share your thoughts on this.
>>
>> A known thing is that we will lose the last history of such codebase while
>> doing this re-factoring.
>>
>> Any other ideas to solve the problem are most welcome.
>> --
>> Best Regards,
>> Suraj Khurana
>> Senior Technical Consultant
>>
>
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Michael Brohl <mi...@ecomify.de>.
Hi Suraj,
+1 for the refactoring in general. What history do we lose while
refactoring?
Thanks,
Michael
Am 30.05.20 um 18:25 schrieb Suraj Khurana:
> Hello Devs,
>
> Hope you are doing good !!
>
> Currently, there are many checkstyle issues in code base which are due to
> formatting best practices, like indentation, using spaces before/after
> symbols etc.
>
> We can solve many thousands of such issues by correcting all such
> occurrences. Please share your thoughts on this.
>
> A known thing is that we will lose the last history of such codebase while
> doing this re-factoring.
>
> Any other ideas to solve the problem are most welcome.
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
Re: IMPROVEMENT: Checkstyle formatting issues
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Suraj,
I tend to agree, most of the time the history can be rebuild with blame using lines around, or even looking into commits.
Jacques
Le 30/05/2020 à 18:25, Suraj Khurana a écrit :
> Hello Devs,
>
> Hope you are doing good !!
>
> Currently, there are many checkstyle issues in code base which are due to
> formatting best practices, like indentation, using spaces before/after
> symbols etc.
>
> We can solve many thousands of such issues by correcting all such
> occurrences. Please share your thoughts on this.
>
> A known thing is that we will lose the last history of such codebase while
> doing this re-factoring.
>
> Any other ideas to solve the problem are most welcome.
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant