You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/11/23 12:11:18 UTC

[GitHub] jiazhai opened a new issue #769: defect of merge script: some times not able to get reviewers list

jiazhai opened a new issue #769: defect of merge script: some times not able to get reviewers list
URL: https://github.com/apache/bookkeeper/issues/769
 
 
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do?
   merge PR #727.
   
   - What did you expect to see?
   merge success
   
   - What did you see instead?
   reported no approvals while we have 3.
   ```
   bookkeeper git:(master) ? python dev/bk-merge-pr.py
   git rev-parse --abbrev-ref HEAD
   Which pull request would you like to merge? (e.g. 34): 727
   No approvals found in this pull request
   git rev-parse --abbrev-ref HEAD
   git branch
   ```
   
   After I add another comments which contains "+1, lgtm", it could be merged, but it could only get myid, without other 3 approvals Id.  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services