You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Akash Ashok (JIRA)" <ji...@apache.org> on 2011/06/20 12:28:47 UTC
[jira] [Created] (HBASE-4008) Problem while stopping HBase
Problem while stopping HBase
----------------------------
Key: HBASE-4008
URL: https://issues.apache.org/jira/browse/HBASE-4008
Project: HBase
Issue Type: Bug
Components: scripts
Reporter: Akash Ashok
Priority: Minor
stop-hbase.sh stops the server successfully if and only if the server is instantiate properly.
When u Run
start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
Whereas when u run
start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Ashok updated HBASE-4008:
-------------------------------
Fix Version/s: 0.92.0
Labels: HMaster (was: )
Status: Patch Available (was: In Progress)
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062098#comment-13062098 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
yeah was thinking of that. Would that result in any issues ?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062091#comment-13062091 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
I think the main issue is in HMaster.run() method which on throwing an exception aborts all the HMaster threads and neatly executes finally block and exits which in turn would result in HMasterCommandLine thinking that HMaster has started because it hasn't thrown an exception and returns 0. I think we have to throw any exception within HMaster.run() and let it rise thru the stack and let HMasterCommandLine also handle it.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Ashok updated HBASE-4008:
-------------------------------
Priority: Major (was: Minor)
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Ashok updated HBASE-4008:
-------------------------------
Attachment: HBase-4008.patch
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Attachments: HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087259#comment-13087259 ]
stack commented on HBASE-4008:
------------------------------
Akash: My motivation is keeping the public API as narrow as possible. I'll make it protected on commit and then if someone else makes good arg. that they need it public, we'll deal then. Does this patch work for you? If so, I'll commit w/ above change.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4008:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Akash.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062121#comment-13062121 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
Only thing I fear is catching the exception thrown from the HMaster threads using an UncaughtExceptionHandler. So that should be a fairly simple change. Would check it out !
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066311#comment-13066311 ]
stack commented on HBASE-4008:
------------------------------
Akash: Yes. Thats what should happen. My guess is that this interlocking case where RegionServer and Master (and ZK) are up in the one JVM and one of the 'servers' fails, then all should fail, was just never considered. If you could fix it, you'd be a good man.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062112#comment-13062112 ]
stack commented on HBASE-4008:
------------------------------
Not that I know of.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061681#comment-13061681 ]
stack commented on HBASE-4008:
------------------------------
@Akash Yes.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126167#comment-13126167 ]
stack commented on HBASE-4008:
------------------------------
@Jignesh Added comment on closed issue is usually not a good way to get help. I'd say do mailing list first. Look in your logs too first to see why hbase is not going down. Also what version of hbase you should say when asking on mailing list. Does it have the above patch? Is it same issue?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Ashok updated HBASE-4008:
-------------------------------
Attachment: HBase-4008-v2.patch
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052709#comment-13052709 ]
stack commented on HBASE-4008:
------------------------------
bq. Shouldn't it be the case that if a serious exception is thrown the HMaster process should die?
Yes.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071515#comment-13071515 ]
stack commented on HBASE-4008:
------------------------------
I think isAborted belongs in the Abortable Interface. That'd be a big change though. Wouldn't wish that on you (Could do it in another issue -- this is not the first time isAborted has been wanted).
Otherwise, do you think it should be protected rather than public since it is only used by HMasterCommandLine, at least currently.
Else, patch looks great. Does it work for you Akash?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089609#comment-13089609 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
<blockquote >
<p>Also about including the isAborted in the Abortable interface is there a JIRA already open for this? Could I take that up ? </p>
<p>No. Please.</p>
</blockquote>
@Stack: I'm kinda confused. Just wanted to clarify. Did u mean another JIRA is not open and I could take it up. Or did u ask me not to take it up? :) :)
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066098#comment-13066098 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
I have a question regarding the standalone HBase which might not be a real world scenario but fixing this issue I need to know what the behaviour should be after the fix. So for a standalone HBase setup if the HMaster throws a severe exception and master doesn't come up then HBase doesn't stop and goes to an inconsistent.
In the case of True Distributed Mode only HMaster goes down as it runs on a separate JVM.
But how about a standalone case where exiting the JVM causes the RegionServer threads also to be terminated ? In such a case master fails whole standalone HBase setup goes down. This makes logical sense as its a single node setup. Just wanted to clarify if this is ok.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087246#comment-13087246 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
Making it protected works for me. Because it isn't used by anything else currently. But I am thinking making it protected means only the class or the subclasses or the classes in the same package is able to call this method. So it means we are intending this method to be used only by subclasses or within same package. Just like isStopped() or isActiveMaster() even isAborted() has the potential to be called from somehwere outside the package. So based on how it could be called it could still be public. I would love to hear your thoughts on this.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087465#comment-13087465 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
Ok sure This patch works for me. Thanks.
Also about including the isAborted in the Abortable interface is there a JIRA already open for this? Could I take that up ?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-4008 started by Akash Ashok.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087494#comment-13087494 ]
stack commented on HBASE-4008:
------------------------------
bq. Also about including the isAborted in the Abortable interface is there a JIRA already open for this? Could I take that up ?
No. Please.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062095#comment-13062095 ]
stack commented on HBASE-4008:
------------------------------
Want to throw a RuntimeException Akash?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Jignesh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126158#comment-13126158 ]
Jignesh commented on HBASE-4008:
--------------------------------
When I am trying to stop Hbase it goes in infinite loop.
Jignesh-MacBookPro:hadoop-hbase hadoop-user$ bin/stop-hbase.sh
stopping hbase................................................................................................................................................................................................................................................................................................................................................................................
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062314#comment-13062314 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
Hey I am not sure how to handle if any Exceptions were thrown by the HMaster threads as these any Exceptions just terminate the threads leaving the HMasterCommandLine thinking that Master has started successfully. These Exceptions can't be propogated to HMasterCommandLine. Any idea on how this could be handled ?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087561#comment-13087561 ]
Hudson commented on HBASE-4008:
-------------------------------
Integrated in HBase-TRUNK #2125 (See [https://builds.apache.org/job/HBase-TRUNK/2125/])
HBASE-4008 Problem while stopping HBase
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052433#comment-13052433 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
Also this problem exists with the current startup of HMaster that if any Exception is thrown during the startup of the master then HMaster will still be running as a process but its meaningless. stop-hbase.sh fails even then. Shouldn't it be the case that if a serious exception is thrown the HMaster process should die?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Ashok reassigned HBASE-4008:
----------------------------------
Assignee: Akash Ashok
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089750#comment-13089750 ]
stack commented on HBASE-4008:
------------------------------
@Akash Pardon my terseness. Please open a new issue to add isAbortable. I do not of an existing issue.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Labels: HMaster
> Fix For: 0.92.0
>
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066575#comment-13066575 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
Attaching HBase-4008-v2.patch as the first one had an extra unused import.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Attachments: HBase-4008-v2.patch, HBase-4008.patch
>
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052233#comment-13052233 ]
Jean-Daniel Cryans commented on HBASE-4008:
-------------------------------------------
It's a weird use case... but looking at the .out file, I can see the following:
{code}
11/06/20 14:35:32 INFO client.HConnectionManager$HConnectionImplementation: getMaster attempt 0 of 1 failed; no more retrying.
org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningException: Server is not running yet
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1038)
at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:771)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Invoker.invoke(HBaseRPC.java:257)
at $Proxy4.getProtocolVersion(Unknown Source)
at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:419)
at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:393)
at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:444)
at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:360)
at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:89)
at org.apache.hadoop.hbase.master.HMasterCommandLine.stopMaster(HMasterCommandLine.java:163)
at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:104)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:76)
at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1078)
11/06/20 14:35:32 ERROR master.HMasterCommandLine: Master not running
{code}
It seems we should retry if it says that the master isn't running yet instead of ERROR'ing out and leaving the bash script hanging.
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053773#comment-13053773 ]
Akash Ashok commented on HBASE-4008:
------------------------------------
If such is the case, can I change this bug priority to Major?
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
Posted by "Akash Ashok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Ashok updated HBASE-4008:
-------------------------------
Description:
stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
When u Run
start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
Whereas when u run
start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
was:
stop-hbase.sh stops the server successfully if and only if the server is instantiate properly.
When u Run
start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
Whereas when u run
start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
> Problem while stopping HBase
> ----------------------------
>
> Key: HBASE-4008
> URL: https://issues.apache.org/jira/browse/HBASE-4008
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Akash Ashok
> Priority: Minor
>
> stop-hbase.sh stops the server successfully if and only if the server is instantiated properly.
> When u Run
> start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues )
> Whereas when u run
> start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira