You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/21 13:38:48 UTC
[GitHub] [iotdb] 2b3c511 opened a new pull request, #7076: [IOTDB-4183] grafana plugins
2b3c511 opened a new pull request, #7076:
URL: https://github.com/apache/iotdb/pull/7076
grafana plugins: the data of BOOL dataType cannot be displayed properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7076: [IOTDB-4183] Display the data of BOOL dataType in grafana plugin
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7076:
URL: https://github.com/apache/iotdb/pull/7076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7076: [IOTDB-4183] grafana plugins
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7076:
URL: https://github.com/apache/iotdb/pull/7076#discussion_r952435275
##########
server/src/main/java/org/apache/iotdb/db/protocol/rest/handler/QueryDataSetHandler.java:
##########
@@ -294,7 +294,9 @@ private static void fillSourceRowRecordIntoTargetDataSet(
targetDataSetColumn.add(
sourceDataSetField.getDataType().equals(TSDataType.TEXT)
? sourceDataSetField.getStringValue()
- : sourceDataSetField.getObjectValue(sourceDataSetField.getDataType()));
+ : sourceDataSetField.getDataType().equals(TSDataType.BOOLEAN)
+ ? sourceDataSetField.getStringValue().equalsIgnoreCase("true") ? 1 : 0
+ : sourceDataSetField.getObjectValue(sourceDataSetField.getDataType()));
Review Comment:
Better move it to plugin layer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org