You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/21 20:45:22 UTC
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4499
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs of the repo.
Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
---
M .gitignore
M bin/check-rat-report.py
M testdata/bin/copy-udfs-udas.sh
M testdata/udfs/README
D testdata/udfs/impala-hive-udfs.jar
M tests/test-hive-udfs/src/main/java/com/cloudera/impala/TestUpdateUdf.java
6 files changed, 44 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/4499/1
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4499/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:
Line 58: find . -type f -name 'TestUpdateUdf.java' -execdir \
> Seems cleaner to mention the expected .java file by name and not wildcard.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs of the repo.
This patch removes from the repo the single JAR there, which was a
version of a JAR that is built during data load, with one string
changed. The JAR is used only for testing.
Instead of building that jar with the different string and saving the
result in git, daa loading will now build the jar twice, with one Java
source file slightly changed.
Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Reviewed-on: http://gerrit.cloudera.org:8080/4499
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M .gitignore
M bin/check-rat-report.py
M testdata/bin/copy-udfs-udas.sh
M testdata/udfs/README
D testdata/udfs/impala-hive-udfs.jar
M tests/test-hive-udfs/src/main/java/com/cloudera/impala/TestUpdateUdf.java
6 files changed, 46 insertions(+), 42 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs of the repo.
This patch removes from the repo the single JAR there, which was a
version of a JAR that is built during data load, with one string
changed. The JAR is used only for testing.
Instead of building that jar with the different string and saving the
result in git, daa loading will now build the jar twice, with one Java
source file slightly changed.
Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
---
M .gitignore
M bin/check-rat-report.py
M testdata/bin/copy-udfs-udas.sh
M testdata/udfs/README
D testdata/udfs/impala-hive-udfs.jar
M tests/test-hive-udfs/src/main/java/com/cloudera/impala/TestUpdateUdf.java
6 files changed, 46 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/4499/3
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs of the repo.
This patch removes from the repo the single JAR there, which was a
version of a JAR that is built during data load, with one string
changed. The JAR is used only for testing.
Instead of building that jar with the different string and saving the
result in git, daa loading will now build the jar twice, with one Java
source file slightly changed.
Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
---
M .gitignore
M bin/check-rat-report.py
M testdata/bin/copy-udfs-udas.sh
M testdata/udfs/README
D testdata/udfs/impala-hive-udfs.jar
M tests/test-hive-udfs/src/main/java/com/cloudera/impala/TestUpdateUdf.java
6 files changed, 44 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/4499/2
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4499/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs-udas.sh:
Line 58: find . -type f -name '*.java' -execdir bash -c "sed -i s/'Old UDF'/'New UDF'/g '{}'" \;
Seems cleaner to mention the expected .java file by name and not wildcard.
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icee7b8c32b08e064dea4a14624acff6021ef5ce1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No