[GitHub] [arrow-rs] alamb commented on a diff in pull request #4012: Add FlightSQL module docs and links to `arrow-flight` crates

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4012:
URL: https://github.com/apache/arrow-rs/pull/4012#discussion_r1157661289


##########
arrow-flight/src/lib.rs:
##########
@@ -30,6 +30,11 @@
 //!
 //! 2. Low level [tonic] generated [`flight_service_client`] and
 //! [`flight_service_server`].
+//!
+//! 3. Experimental support for [Flight SQL] in [`sql`]. Requires the

Review Comment:
   Yeah, I think we were just trying to give people the heads up that we would likely be making substantial changes to the API -- but then we do that with other parts of arrow, so maybe the extra "experimental" part is unecessary.
   
   What do you think @tustvold  / @viirya  -- should we rename the feature flag from experimental (and maybe turn it on by default?)



##########
arrow-flight/src/sql/mod.rs:
##########
@@ -15,6 +15,26 @@
 // specific language governing permissions and limitations
 // under the License.
 
+//! Support for execute SQL queries using [Apache Arrow] [Flight SQL].
+//!
+//! [Flight SQL] is built on top of Arrow Flight RPC framework, by

Review Comment:
   Good idea -- done in 7c8f3e172



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org