You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/07/19 05:08:48 UTC
[GitHub] carbondata pull request #2521: [CARBONDATA-2751] Fixed Thread leak issue in ...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2521#discussion_r203602958
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java ---
@@ -184,12 +190,14 @@ private void processRange(Iterator<CarbonRowBatch> insideRangeIterator,
dataHandler = CarbonFactHandlerFactory
.createCarbonFactHandler(model);
dataHandler.initialise();
+ carbonFactHandlers.add(dataHandler);
--- End diff --
Better add before initialize, so can you move this line above.
---