You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "chungen0126 (via GitHub)" <gi...@apache.org> on 2024/05/04 21:45:56 UTC
[PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
chungen0126 opened a new pull request, #6638:
URL: https://github.com/apache/ozone/pull/6638
## What changes were proposed in this pull request?
AbstractContractLeaseRecoveryTest is abstract. No subclasses implements it. That is to say, Ozone doesn't run lease recovery contract tests. We don't know if Ozone's lease recovery APIs behavior perform according to the contracts.
Please describe your PR in detail:
- Add AbstractContractLeaseRecoveryTest to AbstractOzoneContractTest.
- Ensure lease recovery comply with the contract.
- Fix some existing tests to assert the same exception as AbstractContractLeaseRecoveryTest.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10754
## How was this patch tested?
It was tested at `TestOzoneContractFSO` and `TestRootedOzoneContract`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on code in PR #6638:
URL: https://github.com/apache/ozone/pull/6638#discussion_r1590708246
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/contract/TestOzoneContractFSO.java:
##########
@@ -20,7 +20,6 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.contract.AbstractFSContract;
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
-
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #6638:
URL: https://github.com/apache/ozone/pull/6638#discussion_r1590549961
##########
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/RootedOzoneFileSystem.java:
##########
@@ -135,6 +137,14 @@ public boolean hasPathCapability(final Path path, final String capability)
if (cap) {
return cap;
}
+ // this switch is for features which are in the OFS client.
+ switch (validatePathCapabilityArgs(path, capability)) {
Review Comment:
Besides this [RootedOzoneFileSystem.java](https://github.com/apache/ozone/pull/6638/files#diff-8e219ae2e7dcd13144bf5e888a9c34dc5cfecd34b68518d030943f10e29d35aa), there is another one with same name for ozonefs-hadoop3.
[OzoneFileSystem.java](https://github.com/apache/ozone/pull/6638/files#diff-7a4c4b8ec4a88d0e4d8eac32c63c5c10bb868a39ada854fe97f6ce6825133171) is the same, there are 2 files.
Please put this CommonPathCapabilities.LEASE_RECOVERABLE check into OzonePathCapabilities.hasPathCapability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #6638:
URL: https://github.com/apache/ozone/pull/6638#discussion_r1590608277
##########
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java:
##########
@@ -135,6 +137,14 @@ public boolean hasPathCapability(final Path path, final String capability)
if (cap) {
return cap;
}
+ // this switch is for features which are in the OFS client.
+ switch (validatePathCapabilityArgs(path, capability)) {
+ case CommonPathCapabilities.LEASE_RECOVERABLE:
Review Comment:
is there a reason not adding this switch case to OzonePathCapabilities.hasPathCapability() instead?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/contract/TestOzoneContractFSO.java:
##########
@@ -20,7 +20,6 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.contract.AbstractFSContract;
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
-
Review Comment:
remove this change in the next iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on code in PR #6638:
URL: https://github.com/apache/ozone/pull/6638#discussion_r1590708061
##########
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/RootedOzoneFileSystem.java:
##########
@@ -135,6 +137,14 @@ public boolean hasPathCapability(final Path path, final String capability)
if (cap) {
return cap;
}
+ // this switch is for features which are in the OFS client.
+ switch (validatePathCapabilityArgs(path, capability)) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #6638:
URL: https://github.com/apache/ozone/pull/6638#discussion_r1590549961
##########
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/RootedOzoneFileSystem.java:
##########
@@ -135,6 +137,14 @@ public boolean hasPathCapability(final Path path, final String capability)
if (cap) {
return cap;
}
+ // this switch is for features which are in the OFS client.
+ switch (validatePathCapabilityArgs(path, capability)) {
Review Comment:
Please put this CommonPathCapabilities.LEASE_RECOVERABLE check into OzonePathCapabilities.hasPathCapability.
Besides this [RootedOzoneFileSystem.java](https://github.com/apache/ozone/pull/6638/files#diff-8e219ae2e7dcd13144bf5e888a9c34dc5cfecd34b68518d030943f10e29d35aa), there is another one with same name for ozonefs-hadoop3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on code in PR #6638:
URL: https://github.com/apache/ozone/pull/6638#discussion_r1590708471
##########
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java:
##########
@@ -135,6 +137,14 @@ public boolean hasPathCapability(final Path path, final String capability)
if (cap) {
return cap;
}
+ // this switch is for features which are in the OFS client.
+ switch (validatePathCapabilityArgs(path, capability)) {
+ case CommonPathCapabilities.LEASE_RECOVERABLE:
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10754. [hsync] lease recovery contract test class not substantiated [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi merged PR #6638:
URL: https://github.com/apache/ozone/pull/6638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org