You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 01:05:57 UTC

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4447: fix `push_down_filter` push `Expr` instead of `column`.

jackwener commented on code in PR #4447:
URL: https://github.com/apache/arrow-datafusion/pull/4447#discussion_r1036594951


##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -643,18 +643,25 @@ impl OptimizerRule for PushDownFilter {
                 for expr in predicates {
                     let columns = expr.to_columns()?;
                     if columns.is_empty()
-                        || !columns
-                            .intersection(&used_columns)
-                            .collect::<HashSet<_>>()
-                            .is_empty()

Review Comment:
   The original performance was bad



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org