[GitHub] [arrow] westonpace commented on pull request #13108: ARROW-15415: [C++] Fixes for MSVC + vcpkg Debug build

[GitBox <gi...@apache.org>]

westonpace commented on PR #13108:
URL: https://github.com/apache/arrow/pull/13108#issuecomment-1149077261

   > I'm not sure what you mean by this. It seems like we want to have Get() return opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span> if #ifdef ARROW_WITH_OPENTELEMETRY, but not expose that condition in the header file. Not sure how a virtual class helps hide that.
   
   Then you can make the `Get` methods a part of the subclass and force callers to do a checked / dynamic cast.  Since these methods are called primarily from helper-macros this shouldn't make any real difference to normal usage of the type.
   
   Or we just create our own `Span` that proxies the surface of `opentelemetry::trace::Span` that we care about and then not use `opentelemetry::trace::Span` anywhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org