You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:39:24 UTC

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #1182: nimble/ll: Fix scan proc handling

sjanc commented on a change in pull request #1182:
URL: https://github.com/apache/mynewt-nimble/pull/1182#discussion_r809119080



##########
File path: nimble/controller/src/ble_ll_scan.c
##########
@@ -1091,6 +1091,10 @@ ble_ll_scan_event_proc(struct ble_npl_event *ev)
      */
     start_scan = inside_window;
     switch (ble_ll_state_get()) {
+#if MYNEWT_VAL(BLE_LL_ROLE_BROADCASTER) || MYNEWT_VAL(BLE_LL_ROLE_PERIPHERAL) || \

Review comment:
       I'd set start_scan=false explicitly in each case instead of this combined #if




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org