You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "gemmellr (via GitHub)" <gi...@apache.org> on 2023/04/05 14:26:26 UTC
[GitHub] [activemq-website] gemmellr opened a new pull request, #108: Update bootstrap to resolve build deprecation warnings
gemmellr opened a new pull request, #108:
URL: https://github.com/apache/activemq-website/pull/108
When using new jekyll [sass converter] versions several notices (see snippet below) are made around the boostrap [s]css bits, warning of deprecated behaviour that will break in future updates.
It prints these several warnings on every refresh build, making it difficult to see the actual build output.
The latest 4.x bootstrap releases contain fixes for the same from https://github.com/twbs/bootstrap/commit/8dec3d0a3430baa583c1c7050648ee37132acddc. Applying similar change locally proved awkward as the context has changed a bunch of other ways prior to that, so instead this change updates the bootstrap version.
I reviewed the homepage and all the main menu linked pages and the various download pages, plus a selection of documentation pages for each component. I only noticed 2 visual changes from the update: the size of the date text in the news listings on the homepage increased slightly, and the download + documentation buttons on each component page changed to adopt the primary green rather than being transparent as before. I liked the new data text better so I left that unchanged, but I applied some additional CSS style in main.scss to make the download + documentation buttons go back to their prior looks.
```
Configuration file: /path/to/activemq-website/_config.yml
Source: /path/to/activemq-website/src
Destination: /path/to/activemq-website/_site
Incremental build: disabled. Enable with --incremental
Generating...
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacer, 2) or calc($spacer / 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
252 │ $headings-margin-bottom: ($spacer / 2) !default;
│ ^^^^^^^^^^^
╵
/path/to/activemq-website/src/css/bootstrap/_variables.scss 252:32 @import
/path/to/activemq-website/src/css/bootstrap/bootstrap.scss 10:9 @import
/path/to/activemq-website/src/css/main.scss 1:9 root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacer, 2) or calc($spacer / 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
590 │ $navbar-padding-y: ($spacer / 2) !default;
│ ^^^^^^^^^^^
╵
/path/to/activemq-website/src/css/bootstrap/_variables.scss 590:38 @import
/path/to/activemq-website/src/css/bootstrap/bootstrap.scss 10:9 @import
/path/to/activemq-website/src/css/main.scss 1:9 root stylesheet
<etc..etc...snipped>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on pull request #108: Update bootstrap to resolve build deprecation warnings
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on PR #108:
URL: https://github.com/apache/activemq-website/pull/108#issuecomment-1497752140
fixed earlier missing re-application of an old menu fix change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] asfgit merged pull request #108: Update bootstrap to resolve build deprecation warnings
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #108:
URL: https://github.com/apache/activemq-website/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] jbertram commented on pull request #108: Update bootstrap to resolve build deprecation warnings
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #108:
URL: https://github.com/apache/activemq-website/pull/108#issuecomment-1497824852
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org