You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/12/01 04:39:47 UTC

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3363: ARTEMIS-3016 Reduce DuplicateIDCache memory footprint

franz1981 commented on a change in pull request #3363:
URL: https://github.com/apache/activemq-artemis/pull/3363#discussion_r533068562



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/DuplicateIDCacheImpl.java
##########
@@ -69,11 +93,24 @@ public DuplicateIDCacheImpl(final SimpleString address,
 
       ids = new ArrayList<>(size);
 
+      cachedBoxedInts = boxedInts(size);

Review comment:
       I've removed the last commit including the bespoke primitive map: seems that I cannot beat CHM (not a surprise) due to open-addressing nature of the version I've built. Big sized maps, almost full, work best as closed addressing and that's exactly the use case of CHM.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org