[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory
URL: https://github.com/apache/openwhisk/pull/4595#discussion_r318532489
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala
 ##########
 @@ -89,6 +89,17 @@ trait ContainerFactory {
    * - It is desired that the container supports and enforces the specified memory limit and CPU shares.
    *   In particular, action memory limits rely on the underlying container technology.
    */
+  def createContainer(
 
 Review comment:
   Another option can be to just add new parameter to existing method and adapt existing `ContainerFactory` impls signatures

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services